From: Nikita Pettik <korablev@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>,
tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2] vinyl: clean-up read views if *_build_history() fails
Date: Thu, 9 Apr 2020 11:09:32 +0000 [thread overview]
Message-ID: <20200409110932.GB3864@tarantool.org> (raw)
In-Reply-To: <20200409081923.GB21437@atlas>
On 09 Apr 11:19, Konstantin Osipov wrote:
> * Nikita Pettik <korablev@tarantool.org> [20/04/09 00:39]:
> > if (vy_write_iterator_build_history(stream, &raw_count,
> > - &is_first_insert) != 0)
> > + &is_first_insert) != 0) {
> > + for (int i = 0; i < stream->rv_count; ++i)
> > + stream->read_views[i].history = NULL;
>
> This violates stream encapsulation and should be a method of the
> stream.
read_views is a member of write_iterator, not stream. Stream has
only for methods: start, next, stop, close.
vy_write_iterator_build_history() is a part of next method. So it
is likely to be already encapsulated, isn't it? Access to truncated
region memory occurs in stop() method (i.e. write_iterator_stop()).
> Otherwise lgtm.
>
>
> --
> Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-04-09 11:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 21:37 [Tarantool-patches] [PATCH 0/2] vinyl: fix uninitialized memory accesses Nikita Pettik
2020-04-08 21:37 ` [Tarantool-patches] [PATCH 1/2] vinyl: init all vars before cleanup in vy_lsm_split_range() Nikita Pettik
2020-04-09 8:18 ` Konstantin Osipov
2020-04-09 10:55 ` Nikita Pettik
2020-04-09 11:07 ` Konstantin Osipov
2020-04-09 11:26 ` Nikita Pettik
2020-04-10 15:13 ` Vladislav Shpilevoy
2020-04-10 15:40 ` Nikita Pettik
2020-04-10 18:24 ` Nikita Pettik
2020-04-11 17:39 ` Vladislav Shpilevoy
2020-04-13 22:29 ` Nikita Pettik
2020-04-14 21:40 ` Nikita Pettik
2020-04-08 21:37 ` [Tarantool-patches] [PATCH 2/2] vinyl: clean-up read views if *_build_history() fails Nikita Pettik
2020-04-09 8:19 ` Konstantin Osipov
2020-04-09 11:09 ` Nikita Pettik [this message]
2020-04-10 15:13 ` Vladislav Shpilevoy
2020-04-10 15:47 ` Nikita Pettik
2020-04-10 21:45 ` Nikita Pettik
2020-04-10 22:32 ` Vladislav Shpilevoy
2020-04-11 17:30 ` Konstantin Osipov
2020-04-13 22:31 ` Nikita Pettik
2020-04-13 22:35 ` Konstantin Osipov
2020-04-13 22:11 ` Nikita Pettik
2020-04-11 17:39 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409110932.GB3864@tarantool.org \
--to=korablev@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] vinyl: clean-up read views if *_build_history() fails' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox