Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
	Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] Add const qualifier to mp_encode_ext argument
Date: Wed, 8 Apr 2020 20:01:01 +0300	[thread overview]
Message-ID: <20200408170101.465nxb3x5w7djuwq@tkn_work_nb> (raw)
In-Reply-To: <20200403230158.43137-1-sergepetrenko@tarantool.org>

LGTM.

Pushed to tarantool/msgpuck master.

WBR, Alexander Turenko.

On Sat, Apr 04, 2020 at 02:01:58AM +0300, Serge Petrenko wrote:
> ---
> This is a fix needed in scope of tarantool#4268 (UUID type indices introduction)
> 
> https://github.com/tarantool/tarantool/issues/4268
> https://github.com/tarantool/msgpuck/tree/sp/ext-type-fix
> 
>  msgpuck.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/msgpuck.h b/msgpuck.h
> index 59fc1ee..5dfbbd9 100644
> --- a/msgpuck.h
> +++ b/msgpuck.h
> @@ -570,7 +570,7 @@ mp_encode_extl(char *data, int8_t type, uint32_t len);
>   * \sa mp_encode_strl
>   */
>  MP_PROTO char *
> -mp_encode_ext(char *data, int8_t type, char *str, uint32_t len);
> +mp_encode_ext(char *data, int8_t type, const char *str, uint32_t len);
>  
>  /**
>   * \brief Check that \a cur buffer has enough bytes to decode an ext header.
> @@ -1577,7 +1577,7 @@ mp_encode_extl(char *data, int8_t type, uint32_t len)
>  }
>  
>  MP_IMPL char *
> -mp_encode_ext(char *data, int8_t type, char *str, uint32_t len)
> +mp_encode_ext(char *data, int8_t type, const char *str, uint32_t len)
>  {
>  	data = mp_encode_extl(data, type, len);
>  	memcpy(data, str, len);
> -- 
> 2.21.1 (Apple Git-122.3)
> 

      parent reply	other threads:[~2020-04-08 17:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-03 23:01 Serge Petrenko
2020-04-05 19:38 ` Vladislav Shpilevoy
2020-04-08 17:01 ` Alexander Turenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200408170101.465nxb3x5w7djuwq@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] Add const qualifier to mp_encode_ext argument' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox