Tarantool development patches archive
 help / color / mirror / Atom feed
From: Nikita Pettik <korablev@tarantool.org>
To: Chris Sosnin <k.sosnin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/2] session: store output format in struct session
Date: Tue, 7 Apr 2020 21:09:59 +0000	[thread overview]
Message-ID: <20200407210959.GB28079@tarantool.org> (raw)
In-Reply-To: <f5e248fcaa209666492586cb9ad9009474e30d69.1586183184.git.k.sosnin@tarantool.org>

On 06 Apr 17:33, Chris Sosnin wrote:
> diff --git a/src/box/session.h b/src/box/session.h
> index 6dfc7cba5..9ade6e7a5 100644
> --- a/src/box/session.h
> +++ b/src/box/session.h
> @@ -59,6 +59,12 @@ enum session_type {
>  	session_type_MAX,
>  };
>  
> +enum output_format {
> +	OUTPUT_FORMAT_YAML = 0,
> +	OUTPUT_FORMAT_LUA_LINE,
> +	OUTPUT_FORMAT_LUA_BLOCK,
> +};
> +
>

It would be nice to see explanation concering difference between
LUA_LINE and LUA_BLOCK outputs.

LGTM (looks like pure refactoring).
 

  reply	other threads:[~2020-04-07 21:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 14:33 [Tarantool-patches] [PATCH 0/2] fix box.session.push formatting Chris Sosnin
2020-04-06 14:33 ` [Tarantool-patches] [PATCH 1/2] session: store output format in struct session Chris Sosnin
2020-04-07 21:09   ` Nikita Pettik [this message]
2020-04-06 14:33 ` [Tarantool-patches] [PATCH 2/2] box: fix formatting in session.push Chris Sosnin
2020-04-07 21:26   ` Nikita Pettik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200407210959.GB28079@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=k.sosnin@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 1/2] session: store output format in struct session' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox