From: Nikita Pettik <korablev@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] box: fix session.push formatting
Date: Tue, 7 Apr 2020 21:03:16 +0000 [thread overview]
Message-ID: <20200407210316.GA28079@tarantool.org> (raw)
In-Reply-To: <a49b7127-68dc-06d9-f2d2-1bc10ceb976d@tarantool.org>
On 07 Apr 22:29, Vladislav Shpilevoy wrote:
> Hi! I suggest to hurry up, we have the release closer and closer.
Still 54 open issues.
> On 04/04/2020 01:42, Vladislav Shpilevoy wrote:
> > Thanks for the fixes!
> >
> > The patchset LGTM. Except that the changelog is still
> > missing.
> >
> > Please, add a changelog, and send on a second review.
> > I propose either Nikita or Alexander L.
> >
> > On 13/03/2020 15:58, Chris Sosnin wrote:
> >> issue: https://github.com/tarantool/tarantool/issues/4686
> >> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4686-session-push-fmt
> >>
> >> Changes in v2:
> >> - Current format moved to struct session.
> >> - Applied review fixes.
> >>
> >> Chris Sosnin (2):
> >> refactoring: store output format in struct session
> >> box: fix formatting in session.push
> >>
> >> extra/exports | 2 +
> >> src/box/lua/console.c | 53 ++++++++++++++++++--------
> >> src/box/lua/console.lua | 72 +++++++++++++++++++++++++++--------
> >> src/box/session.h | 22 ++++++++---
> >> test/app-tap/console.test.lua | 14 ++++++-
> >> 5 files changed, 126 insertions(+), 37 deletions(-)
> >>
next prev parent reply other threads:[~2020-04-07 21:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 14:58 Chris Sosnin
2020-03-13 14:58 ` [Tarantool-patches] [PATCH v2 1/2] refactoring: store output format in struct session Chris Sosnin
2020-03-15 17:27 ` Vladislav Shpilevoy
2020-03-13 14:58 ` [Tarantool-patches] [PATCH v2 2/2] box: fix formatting in session.push Chris Sosnin
2020-03-15 17:27 ` Vladislav Shpilevoy
2020-03-27 10:26 ` Chris Sosnin
2020-04-02 23:14 ` Vladislav Shpilevoy
2020-04-03 12:38 ` Chris Sosnin
2020-03-15 17:27 ` [Tarantool-patches] [PATCH v2 0/2] box: fix session.push formatting Vladislav Shpilevoy
2020-04-03 23:42 ` Vladislav Shpilevoy
2020-04-07 20:29 ` Vladislav Shpilevoy
2020-04-07 21:03 ` Nikita Pettik [this message]
2020-04-07 21:52 ` Chris Sosnin
2020-04-13 14:23 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407210316.GA28079@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 0/2] box: fix session.push formatting' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox