From: Sergey Bronnikov <sergeyb@tarantool.org>
To: Igor Munkin <imunat@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] Fix luacheck warnings in src/lua/*.lua
Date: Tue, 7 Apr 2020 18:15:12 +0300 [thread overview]
Message-ID: <20200407151512.GA5989@pony.bronevichok.ru> (raw)
In-Reply-To: <20200404093457.GC30022@tarantool.org>
Igor, thanks for your comments. I have updated patch and moved all supressions
from source code to a luacheck config file.
Sergey
On 12:34 Sat 04 Apr , Igor Munkin wrote:
> Sergey,
>
> Thanks for the patch. It's not a review, I just want to add my two cents
> regarding luacheck usage.
>
> 1. Please consider the way style violations are organized in uJIT
> repo[1]. You can also group everything into a single file for better
> further maintenance.
>
> 2. There is also a runner[2] for luacheck, that considers uJIT specifics
> (e.g. ujit table is a global variable similar to Tarantool's box one).
>
> I guess this approach should be considered, even if you decide to make
> the patch your own way.
prev parent reply other threads:[~2020-04-07 15:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 9:39 Sergey Bronnikov
2020-04-03 10:13 ` lvasiliev
2020-04-03 11:03 ` Sergey Bronnikov
2020-04-03 14:21 ` Oleg Babin
2020-04-06 9:33 ` Sergey Bronnikov
2020-04-07 15:39 ` Sergey Bronnikov
2020-04-03 20:39 ` Vladislav Shpilevoy
2020-04-03 22:39 ` Vladislav Shpilevoy
2020-04-07 15:35 ` Sergey Bronnikov
2020-04-04 9:34 ` Igor Munkin
2020-04-07 15:15 ` Sergey Bronnikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407151512.GA5989@pony.bronevichok.ru \
--to=sergeyb@tarantool.org \
--cc=imunat@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] Fix luacheck warnings in src/lua/*.lua' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox