Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: [Tarantool-patches] [PATCH v12 3/8] request: add missing OutOfMemory diag_set
Date: Tue,  7 Apr 2020 18:14:56 +0300	[thread overview]
Message-ID: <20200407151500.3410-4-gorcunov@gmail.com> (raw)
In-Reply-To: <20200407151500.3410-1-gorcunov@gmail.com>

In request_create_from_tuple and request_handle_sequence
we may be unable to request memory for tuples, don't
forget to setup diag error otherwise diag_raise will
lead to nil dereference.

Acked-by: Sergey Ostanevich <sergos@tarantool.org>
Acked-by: Konstantin Osipov <kostja.osipov@gmail.com>
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
 src/box/request.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/box/request.c b/src/box/request.c
index 82232a155..994f2da62 100644
--- a/src/box/request.c
+++ b/src/box/request.c
@@ -109,8 +109,10 @@ request_create_from_tuple(struct request *request, struct space *space,
 		 * the tuple data to WAL on commit.
 		 */
 		char *buf = region_alloc(&fiber()->gc, size);
-		if (buf == NULL)
+		if (buf == NULL) {
+			diag_set(OutOfMemory, size, "region_alloc", "tuple");
 			return -1;
+		}
 		memcpy(buf, data, size);
 		request->tuple = buf;
 		request->tuple_end = buf + size;
@@ -199,8 +201,10 @@ request_handle_sequence(struct request *request, struct space *space)
 		size_t buf_size = (request->tuple_end - request->tuple) +
 						mp_sizeof_uint(UINT64_MAX);
 		char *tuple = region_alloc(&fiber()->gc, buf_size);
-		if (tuple == NULL)
+		if (tuple == NULL) {
+			diag_set(OutOfMemory, buf_size, "region_alloc", "tuple");
 			return -1;
+		}
 		char *tuple_end = mp_encode_array(tuple, len);
 
 		if (unlikely(key != data)) {
-- 
2.20.1

  parent reply	other threads:[~2020-04-07 15:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07 15:14 [Tarantool-patches] [PATCH v12 0/8] replication: prevent nil dereference on applier rollback Cyrill Gorcunov
2020-04-07 15:14 ` [Tarantool-patches] [PATCH v12 1/8] box: fix bootstrap comment Cyrill Gorcunov
2020-04-07 15:14 ` [Tarantool-patches] [PATCH v12 2/8] alter: shrink txn_alter_trigger_new code Cyrill Gorcunov
2020-04-07 15:14 ` Cyrill Gorcunov [this message]
2020-04-07 15:14 ` [Tarantool-patches] [PATCH v12 4/8] applier: add missing diag_set on region_alloc failure Cyrill Gorcunov
2020-04-07 15:14 ` [Tarantool-patches] [PATCH v12 5/8] replication: merge replica_by_id into replicaset Cyrill Gorcunov
2020-04-07 15:14 ` [Tarantool-patches] [PATCH v12 6/8] applier: reduce applier_txn_rollback_cb code density Cyrill Gorcunov
2020-04-07 15:15 ` [Tarantool-patches] [PATCH v12 7/8] applier: prevent nil dereference on applier rollback Cyrill Gorcunov
2020-04-07 15:15 ` [Tarantool-patches] [PATCH v12 8/8] test: add replication/gh-4730-applier-rollback Cyrill Gorcunov
2020-04-08 11:04 ` [Tarantool-patches] [PATCH v12 0/8] replication: prevent nil dereference on applier rollback Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200407151500.3410-4-gorcunov@gmail.com \
    --to=gorcunov@gmail.com \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v12 3/8] request: add missing OutOfMemory diag_set' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox