From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: [Tarantool-patches] [PATCH v12 2/8] alter: shrink txn_alter_trigger_new code
Date: Tue, 7 Apr 2020 18:14:55 +0300 [thread overview]
Message-ID: <20200407151500.3410-3-gorcunov@gmail.com> (raw)
In-Reply-To: <20200407151500.3410-1-gorcunov@gmail.com>
Instead of calling memset which is useless here
just use trigger_create helper.
Acked-by: Konstantin Osipov <kostja.osipov@gmail.com>
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
src/box/alter.cc | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/box/alter.cc b/src/box/alter.cc
index d73679fb8..dbbbcbc44 100644
--- a/src/box/alter.cc
+++ b/src/box/alter.cc
@@ -820,9 +820,7 @@ txn_alter_trigger_new(trigger_f run, void *data)
diag_set(OutOfMemory, size, "region", "struct trigger");
return NULL;
}
- trigger = (struct trigger *)memset(trigger, 0, size);
- trigger->run = run;
- trigger->data = data;
+ trigger_create(trigger, run, data, NULL);
return trigger;
}
--
2.20.1
next prev parent reply other threads:[~2020-04-07 15:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 15:14 [Tarantool-patches] [PATCH v12 0/8] replication: prevent nil dereference on applier rollback Cyrill Gorcunov
2020-04-07 15:14 ` [Tarantool-patches] [PATCH v12 1/8] box: fix bootstrap comment Cyrill Gorcunov
2020-04-07 15:14 ` Cyrill Gorcunov [this message]
2020-04-07 15:14 ` [Tarantool-patches] [PATCH v12 3/8] request: add missing OutOfMemory diag_set Cyrill Gorcunov
2020-04-07 15:14 ` [Tarantool-patches] [PATCH v12 4/8] applier: add missing diag_set on region_alloc failure Cyrill Gorcunov
2020-04-07 15:14 ` [Tarantool-patches] [PATCH v12 5/8] replication: merge replica_by_id into replicaset Cyrill Gorcunov
2020-04-07 15:14 ` [Tarantool-patches] [PATCH v12 6/8] applier: reduce applier_txn_rollback_cb code density Cyrill Gorcunov
2020-04-07 15:15 ` [Tarantool-patches] [PATCH v12 7/8] applier: prevent nil dereference on applier rollback Cyrill Gorcunov
2020-04-07 15:15 ` [Tarantool-patches] [PATCH v12 8/8] test: add replication/gh-4730-applier-rollback Cyrill Gorcunov
2020-04-08 11:04 ` [Tarantool-patches] [PATCH v12 0/8] replication: prevent nil dereference on applier rollback Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407151500.3410-3-gorcunov@gmail.com \
--to=gorcunov@gmail.com \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v12 2/8] alter: shrink txn_alter_trigger_new code' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox