From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v11 1/8] box: fix bootstrap comment
Date: Sun, 5 Apr 2020 11:35:22 +0300 [thread overview]
Message-ID: <20200405083522.GA4900@atlas> (raw)
In-Reply-To: <20200405075622.GC3072@uranus>
* Cyrill Gorcunov <gorcunov@gmail.com> [20/04/05 11:00]:
> On Sun, Apr 05, 2020 at 10:31:40AM +0300, Konstantin Osipov wrote:
> > * Cyrill Gorcunov <gorcunov@gmail.com> [20/04/05 05:06]:
> > > We're not starting new master node but
> > > a new instance instead. The comment simply
> > > leftover from older modifications.
> >
> > I wrote it and it had a meaning. If we call bootstrap, it's
> > definitely a new master here, because we're creating a new
> > replicaset uuid.
>
> Wait, this looks vague. Here what we have inside
Sorry, I looked out of the context. My comment is indeed obsolete,
perhaps some code rot. The patch is lgtm.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-04-05 8:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-04 16:15 [Tarantool-patches] [PATCH v11 0/8] box/replication: prevent nil dereference on applier rollback Cyrill Gorcunov
2020-04-04 16:15 ` [Tarantool-patches] [PATCH v11 1/8] box: fix bootstrap comment Cyrill Gorcunov
2020-04-05 7:31 ` Konstantin Osipov
2020-04-05 7:56 ` Cyrill Gorcunov
2020-04-05 8:35 ` Konstantin Osipov [this message]
2020-04-04 16:15 ` [Tarantool-patches] [PATCH v11 2/8] box/alter: shrink txn_alter_trigger_new code Cyrill Gorcunov
2020-04-06 7:39 ` Konstantin Osipov
2020-04-04 16:15 ` [Tarantool-patches] [PATCH v11 3/8] box/request: add missing OutOfMemory diag_set Cyrill Gorcunov
2020-04-04 16:15 ` [Tarantool-patches] [PATCH v11 4/8] box/applier: add missing diag_set on region_alloc failure Cyrill Gorcunov
2020-04-04 16:15 ` [Tarantool-patches] [PATCH v11 5/8] box/replication: merge replica_by_id into replicaset Cyrill Gorcunov
2020-04-06 7:40 ` Konstantin Osipov
2020-04-04 16:15 ` [Tarantool-patches] [PATCH v11 6/8] applier: reduce applier_txn_rollback_cb code density Cyrill Gorcunov
2020-04-06 7:40 ` Konstantin Osipov
2020-04-04 16:15 ` [Tarantool-patches] [PATCH v11 7/8] box/applier: prevent nil dereference on applier rollback Cyrill Gorcunov
2020-04-07 10:36 ` Serge Petrenko
2020-04-04 16:15 ` [Tarantool-patches] [PATCH v11 8/8] test: add replication/applier-rollback Cyrill Gorcunov
2020-04-07 10:26 ` Serge Petrenko
2020-04-07 10:55 ` Cyrill Gorcunov
2020-04-07 10:46 ` [Tarantool-patches] [PATCH v11 0/8] box/replication: prevent nil dereference on applier rollback Serge Petrenko
2020-04-07 11:00 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200405083522.GA4900@atlas \
--to=kostja.osipov@gmail.com \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v11 1/8] box: fix bootstrap comment' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox