From: Nikita Pettik <korablev@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] box: always promote error created via box.error() to diag
Date: Fri, 3 Apr 2020 01:55:40 +0000 [thread overview]
Message-ID: <20200403015540.GC946@tarantool.org> (raw)
In-Reply-To: <91132370-b7d2-cb08-7a42-3f97b29da858@tarantool.org>
On 03 Apr 00:20, Vladislav Shpilevoy wrote:
> Thanks for the fixes!
>
> > commit 28c43bbdb82f78b7a2d19e55de181ddb7d370497
> > Author: Nikita Pettik <korablev@tarantool.org>
> > Date: Wed Apr 1 16:32:22 2020 +0300
> >
> > box: always promote error created via box.error() to diag
> >
> > This patch makes box.error() always promote error to the diagnostic
> > area despite of passed arguments.
> >
> > Closes #4829
> >
> > @TarantoolBot document
> > Title: always promote error created via box.error() to diag
> >
> > box.error() is able to accept two types of argument: either pair of code
> > + reason (box.error{code = 555, reason = 'Arbitrary message'}) or error
>
> This '+' in the beginning of a line turns into a bullet point in
> github markdown. Check 'Preview' when try to create a ticket. You
> can escape it using \+, or move 'code' word on the same line
> before +.
>
Fixed.
prev parent reply other threads:[~2020-04-03 1:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 15:52 Nikita Pettik
2020-04-02 0:37 ` Vladislav Shpilevoy
2020-04-02 14:15 ` Nikita Pettik
2020-04-02 22:20 ` Vladislav Shpilevoy
2020-04-03 1:55 ` Nikita Pettik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403015540.GC946@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] box: always promote error created via box.error() to diag' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox