Re: [Tarantool-patches] [PATCH v2 2/5] static build: remove unneeded LD_LIBRARY_PATH

[Sergey Bronnikov <sergeyb@tarantool.org>]

Sasha,
I propose to add options to handle connection retries in curl.

LGTM

Sergey

On 12:27 Thu 19 Dec , Alexander Tikhonov wrote:
> Igor, thanks for the review, I've added more information in the comment message about the change.
> 
> 
> >Среда, 18 декабря 2019, 15:51 +03:00 от Igor Munkin <imun@tarantool.org>:
> >
> >Sasha,
> >
> >Thanks for the patch! This environment variable has been added within
> >cb1c72d[1] and now you claim that it's excess. Could you please provide
> >a bit more extended rationale for the changes you've made?
> >
> >On 10.12.19, Alexander V. Tikhonov wrote:
> >> Removed LD_LIBRARY_PATH environment from curl build, due to the
> >> path is empty in real and is not needed.
> >> ---
> >>  Dockerfile.staticbuild | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
> >> index 8da8ae304..343627746 100644
> >> --- a/Dockerfile.staticbuild
> >> +++ b/Dockerfile.staticbuild
> >> @@ -56,7 +56,7 @@ RUN set -x && \
> >> 
> >>  RUN set -x && \
> >>      cd / && \
> >> -    LD_LIBRARY_PATH=/usr/local/lib64 curl -O -L  http://download.savannah.nongnu.org/releases/libunwind/libunwind-1.3-rc1.tar.gz && \
> >> +    curl -O -L  http://download.savannah.nongnu.org/releases/libunwind/libunwind-1.3-rc1.tar.gz && \
> >>      tar -xvf libunwind-1.3-rc1.tar.gz && \
> >>      cd libunwind-1.3-rc1 && \
> >>      ./configure --enable-static --enable-shared && \
> >> -- 
> >> 2.17.1
> >> 
> >
> >[1]:  https://github.com/tarantool/tarantool/commit/cb1c72d
> >
> >-- 
> >Best regards,
> >IM
> 
> 
> -- 
> Alexander Tikhonov

-- 
sergeyb@