From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] fiber: abort trace recording on fiber yield
Date: Tue, 31 Mar 2020 19:58:00 +0300 [thread overview]
Message-ID: <20200331165800.GA5079@atlas> (raw)
In-Reply-To: <b77be75a94623c0b430875ec1ad292579f86a613.1585606573.git.imun@tarantool.org>
* Igor Munkin <imun@tarantool.org> [20/03/31 02:06]:
> Since Tarantool fibers doesn't respect Lua coroutine switch mechanism,
> JIT machinery stays unnotified when one lua_State substitues another
> one. As a result if trace recording hasn't been aborted prior to fiber
> switch, the recording proceeds using the new lua_State and leads to
> failure either on any compiler phase or on execution the compiled trace.
>
> This changeset adds a mandatory on_yield trigger aborting trace
> recording when fiber switches to another one.
>
> Fixes #4491
> Closes #1700
This is simply awesome.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-03-31 16:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 22:44 Igor Munkin
2020-03-31 16:58 ` Konstantin Osipov [this message]
2020-03-31 23:57 ` Vladislav Shpilevoy
2020-07-07 22:24 ` Igor Munkin
2020-07-10 10:26 ` sergos
2020-09-21 19:23 ` Igor Munkin
2020-09-21 20:14 ` Sergey Ostanevich
2020-07-11 20:28 ` Vladislav Shpilevoy
2020-09-07 20:35 ` Igor Munkin
2020-09-17 14:21 ` Vladislav Shpilevoy
2020-09-19 15:29 ` Igor Munkin
2020-09-21 20:31 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331165800.GA5079@atlas \
--to=kostja.osipov@gmail.com \
--cc=imun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] fiber: abort trace recording on fiber yield' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox