From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 190B74696C3 for ; Tue, 31 Mar 2020 19:58:03 +0300 (MSK) Received: by mail-lj1-f193.google.com with SMTP id 19so22727046ljj.7 for ; Tue, 31 Mar 2020 09:58:03 -0700 (PDT) Date: Tue, 31 Mar 2020 19:58:00 +0300 From: Konstantin Osipov Message-ID: <20200331165800.GA5079@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH] fiber: abort trace recording on fiber yield List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy * Igor Munkin [20/03/31 02:06]: > Since Tarantool fibers doesn't respect Lua coroutine switch mechanism, > JIT machinery stays unnotified when one lua_State substitues another > one. As a result if trace recording hasn't been aborted prior to fiber > switch, the recording proceeds using the new lua_State and leads to > failure either on any compiler phase or on execution the compiled trace. > > This changeset adds a mandatory on_yield trigger aborting trace > recording when fiber switches to another one. > > Fixes #4491 > Closes #1700 This is simply awesome. -- Konstantin Osipov, Moscow, Russia