From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v5 4/4] box: start counting local space requests separately
Date: Mon, 30 Mar 2020 15:58:53 +0300 [thread overview]
Message-ID: <20200330125853.GF17886@atlas> (raw)
In-Reply-To: <fae6cbe6c40c2107baa2afb99a98f3fadd97e459.1585565637.git.sergepetrenko@tarantool.org>
* Serge Petrenko <sergepetrenko@tarantool.org> [20/03/30 14:08]:
> diff --git a/src/box/box.cc b/src/box/box.cc
> index bf95d1b5e..0762266b0 100644
> --- a/src/box/box.cc
> +++ b/src/box/box.cc
> @@ -1879,6 +1879,23 @@ box_process_subscribe(struct ev_io *io, struct xrow_header *header)
> say_info("remote vclock %s local vclock %s",
> vclock_to_string(&replica_clock), vclock_to_string(&vclock));
>
> + /*
> + * Replica clock is used in gc state and recovery
> + * initialization, so we need to replace the remote 0-th
> + * component with our own one. This doesn't break
> + * recovery: it finds the WAL with a vclock strictly less
> + * than replia clock in all components except the 0th one.
> + * This leads to finding the correct WAL, if it exists,
> + * since we do not need to recover local rows (the ones,
> + * that contribute to the 0-th vclock component).
> + * Note, that it would be bad to set 0-th vclock component
> + * to a smaller value, since it would unnecessarily
> + * require additional WALs, which may have already been
> + * deleted.
> + * Speaking of gc, remote instances' local vclock
> + * components are not used by consumers at all.
> + */
> + vclock_reset(&replica_clock, 0, vclock_get(&replicaset.vclock, 0));
I would love to get rid of any use of vclock_reset() outside
vclock.c, but it seems I can't.
lgtm.
--
Konstantin Osipov, Moscow, Russia
https://scylladb.com
next prev parent reply other threads:[~2020-03-30 12:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 11:04 [Tarantool-patches] [PATCH v5 0/4] replication: fix local space tracking Serge Petrenko
2020-03-30 11:04 ` [Tarantool-patches] [PATCH v5 1/4] vclock: add an ability to reset individual clock components Serge Petrenko
2020-03-30 12:56 ` Konstantin Osipov
2020-04-04 20:51 ` Vladislav Shpilevoy
2020-04-06 8:39 ` Konstantin Osipov
2020-04-07 11:48 ` Serge Petrenko
2020-03-30 11:04 ` [Tarantool-patches] [PATCH v5 2/4] replication: hide 0-th vclock components in replication responses Serge Petrenko
2020-03-30 12:56 ` Konstantin Osipov
2020-04-04 20:51 ` Vladislav Shpilevoy
2020-04-06 8:38 ` Konstantin Osipov
2020-04-07 12:22 ` Serge Petrenko
2020-03-30 11:04 ` [Tarantool-patches] [PATCH v5 3/4] gc: rely on minimal vclock components instead of signatures Serge Petrenko
2020-03-30 12:57 ` Konstantin Osipov
2020-04-04 20:51 ` Vladislav Shpilevoy
2020-04-07 12:40 ` Serge Petrenko
2020-03-30 11:04 ` [Tarantool-patches] [PATCH v5 4/4] box: start counting local space requests separately Serge Petrenko
2020-03-30 12:58 ` Konstantin Osipov [this message]
2020-04-04 20:51 ` Vladislav Shpilevoy
2020-04-07 15:48 ` Serge Petrenko
2020-03-31 11:24 ` [Tarantool-patches] [PATCH v5 0/4] replication: fix local space tracking Serge Petrenko
2020-04-04 20:51 ` Vladislav Shpilevoy
2020-04-07 11:15 ` Serge Petrenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330125853.GF17886@atlas \
--to=kostja.osipov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v5 4/4] box: start counting local space requests separately' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox