From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 2/4] replication: hide 0-th vclock components in replication responses
Date: Mon, 30 Mar 2020 15:52:40 +0300 [thread overview]
Message-ID: <20200330125240.GA17886@atlas> (raw)
In-Reply-To: <1A4735AC-A4B1-4CEA-AC0E-0CA173EFDECE@tarantool.org>
* Serge Petrenko <sergepetrenko@tarantool.org> [20/03/30 14:03]:
> > If you added vclock_compare_ignore0, suggest to introduce and use
> > vclock_copy_ignore0 instead of a pair vclock_copy + vclock_reset.
> Ok. The diff’s below.
The diff is fine. You could make vclock_copy_ingore0 a tad faster
I guess.
Anyway it's already lgtm.
--
Konstantin Osipov, Moscow, Russia
https://scylladb.com
next prev parent reply other threads:[~2020-03-30 12:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 10:20 [Tarantool-patches] [PATCH v4 0/4] replication: fix local space tracking Serge Petrenko
2020-03-27 10:20 ` [Tarantool-patches] [PATCH v4 1/4] vclock: add an ability to reset individual clock components Serge Petrenko
2020-03-27 10:20 ` [Tarantool-patches] [PATCH v4 2/4] replication: hide 0-th vclock components in replication responses Serge Petrenko
2020-03-28 5:57 ` Konstantin Osipov
2020-03-30 11:02 ` Serge Petrenko
2020-03-30 12:52 ` Konstantin Osipov [this message]
2020-03-27 10:20 ` [Tarantool-patches] [PATCH v4 3/4] gc: rely on minimal vclock components instead of signatures Serge Petrenko
2020-03-28 6:03 ` Konstantin Osipov
2020-03-30 11:02 ` Serge Petrenko
2020-03-30 12:54 ` Konstantin Osipov
2020-03-27 10:20 ` [Tarantool-patches] [PATCH v4 4/4] box: start counting local space requests separately Serge Petrenko
2020-03-28 6:17 ` Konstantin Osipov
2020-03-30 11:02 ` Serge Petrenko
2020-03-28 16:23 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330125240.GA17886@atlas \
--to=kostja.osipov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4 2/4] replication: hide 0-th vclock components in replication responses' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox