From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 05/10] box/error: don't set error created via box.error.new to diag
Date: Thu, 26 Mar 2020 21:07:26 +0300 [thread overview]
Message-ID: <20200326180726.sd5fgswki3gaehzw@tkn_work_nb> (raw)
In-Reply-To: <20200326175915.GC5718@tarantool.org>
> > I know there was a discussion about construct vs create vs new.
>
> It was not really discussion, I accidentally didn't notice that
> box_error_construct() in fact allocated memory (meanwhile I thought
> it didn't). I've already renamed it to box_error_new().
>
> > Let me remind about approved name pairs:
> >
> > obj_create/obj_destroy - constructor/destructor, without
> > allocation/deallocation.
> >
> > obj_new/obj_delete - constructor/destructor with
> > allocation/deallocation
> >
> > init/free - library initialization/destruction
> >
> > _construct is not in the vocabulary. I'd avoid it.
>
> Ok, Vlad already guided me (but it would be nice to see this
> manual in our dev docs).
Should be there already: https://github.com/tarantool/doc/issues/1032
next prev parent reply other threads:[~2020-03-26 18:07 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 1:42 [Tarantool-patches] [PATCH v2 00/10] Stacked diagnostics Nikita Pettik
2020-03-25 1:42 ` [Tarantool-patches] [PATCH v2 01/10] box: rfc for stacked diagnostic area Nikita Pettik
2020-03-25 8:27 ` Konstantin Osipov
2020-03-25 14:08 ` Nikita Pettik
2020-03-25 1:42 ` [Tarantool-patches] [PATCH v2 02/10] box: rename diag_add_error to diag_set_error Nikita Pettik
2020-03-25 8:27 ` Konstantin Osipov
2020-03-26 0:22 ` Vladislav Shpilevoy
2020-03-26 12:31 ` Nikita Pettik
2020-03-25 1:42 ` [Tarantool-patches] [PATCH v2 03/10] test: move box.error tests to box/error.test.lua Nikita Pettik
2020-03-25 8:28 ` Konstantin Osipov
2020-03-26 0:22 ` Vladislav Shpilevoy
2020-03-26 12:31 ` Nikita Pettik
2020-03-25 1:43 ` [Tarantool-patches] [PATCH v2 04/10] box/error: introduce box.error.set() method Nikita Pettik
2020-03-25 8:33 ` Konstantin Osipov
2020-03-25 17:41 ` Nikita Pettik
2020-03-26 0:22 ` Vladislav Shpilevoy
2020-03-26 12:31 ` Nikita Pettik
2020-03-25 1:43 ` [Tarantool-patches] [PATCH v2 05/10] box/error: don't set error created via box.error.new to diag Nikita Pettik
2020-03-26 16:50 ` Konstantin Osipov
2020-03-26 17:59 ` Nikita Pettik
2020-03-26 18:06 ` Nikita Pettik
2020-03-26 18:07 ` Alexander Turenko [this message]
2020-03-27 0:19 ` Vladislav Shpilevoy
2020-03-27 13:09 ` Nikita Pettik
2020-03-25 1:43 ` [Tarantool-patches] [PATCH v2 06/10] box: introduce stacked diagnostic area Nikita Pettik
2020-03-26 16:54 ` Konstantin Osipov
2020-03-26 18:03 ` Nikita Pettik
2020-03-26 18:08 ` Konstantin Osipov
2020-03-28 18:40 ` Vladislav Shpilevoy
2020-04-01 16:09 ` Nikita Pettik
2020-04-02 0:29 ` Vladislav Shpilevoy
2020-04-02 17:42 ` Nikita Pettik
2020-04-02 22:20 ` Vladislav Shpilevoy
2020-04-03 1:54 ` Nikita Pettik
2020-04-03 23:17 ` Vladislav Shpilevoy
2020-03-28 18:59 ` Vladislav Shpilevoy
2020-03-31 17:44 ` Nikita Pettik
2020-04-02 0:29 ` Vladislav Shpilevoy
2020-04-02 14:16 ` Nikita Pettik
2020-03-25 1:43 ` [Tarantool-patches] [PATCH v2 07/10] box: use stacked diagnostic area for functional indexes Nikita Pettik
2020-03-30 23:24 ` Vladislav Shpilevoy
2020-04-01 15:53 ` Nikita Pettik
2020-03-25 1:43 ` [Tarantool-patches] [PATCH v2 08/10] box/error: clarify purpose of reference counting in struct error Nikita Pettik
2020-03-30 23:24 ` Vladislav Shpilevoy
2020-03-25 1:43 ` [Tarantool-patches] [PATCH v2 09/10] iproto: refactor error encoding with mpstream Nikita Pettik
2020-03-30 23:24 ` Vladislav Shpilevoy
2020-04-01 15:54 ` Nikita Pettik
2020-03-25 1:43 ` [Tarantool-patches] [PATCH v2 10/10] iproto: support error stacked diagnostic area Nikita Pettik
2020-03-30 23:24 ` Vladislav Shpilevoy
2020-04-01 16:26 ` Nikita Pettik
2020-04-01 22:24 ` Nikita Pettik
2020-04-02 0:29 ` Vladislav Shpilevoy
2020-04-02 14:01 ` Nikita Pettik
2020-04-02 22:20 ` Vladislav Shpilevoy
2020-04-03 2:16 ` Nikita Pettik
2020-04-03 23:17 ` Vladislav Shpilevoy
2020-04-06 11:07 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326180726.sd5fgswki3gaehzw@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 05/10] box/error: don'\''t set error created via box.error.new to diag' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox