From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 2/2] test: unit/popen -- provide a child process
Date: Thu, 26 Mar 2020 12:04:11 +0300 [thread overview]
Message-ID: <20200326090411.GO3197@uranus> (raw)
In-Reply-To: <20200326083122.GN3197@uranus>
On Thu, Mar 26, 2020 at 11:31:22AM +0300, Cyrill Gorcunov wrote:
...
> +
> +static ssize_t
> +read_safe(int pfd, char *dest, ssize_t bytes)
> +{
> + ssize_t left = bytes;
> + ssize_t off = 0;
> +
> + while (left > 0) {
> + ssize_t nr = read(pfd, &dest[off], left);
> + printf("read %zd", nr);
This is redundant printf, I dropped it and force-pushed
into gorcunov/gh-4811-popen-coio-3
next prev parent reply other threads:[~2020-03-26 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 10:03 [Tarantool-patches] [PATCH 0/2] popen: fix unit test Cyrill Gorcunov
2020-03-24 10:03 ` [Tarantool-patches] [PATCH 1/2] popen: do not require space for shell args Cyrill Gorcunov
2020-03-26 0:23 ` Alexander Turenko
2020-03-24 10:03 ` [Tarantool-patches] [PATCH 2/2] test: unit/popen -- provide a child process Cyrill Gorcunov
2020-03-26 0:47 ` Alexander Turenko
2020-03-26 0:59 ` Nikita Pettik
2020-03-26 8:31 ` [Tarantool-patches] [PATCH v2 " Cyrill Gorcunov
2020-03-26 9:04 ` Cyrill Gorcunov [this message]
2020-03-24 10:04 ` [Tarantool-patches] [PATCH 0/2] popen: fix unit test Cyrill Gorcunov
2020-03-26 0:52 ` Alexander Turenko
2020-03-26 11:57 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326090411.GO3197@uranus \
--to=gorcunov@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 2/2] test: unit/popen -- provide a child process' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox