From: Nikita Pettik <korablev@tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 2/2] sql: add '\0' to the BLOB when it is cast to INTEGER
Date: Wed, 25 Mar 2020 18:17:00 +0000 [thread overview]
Message-ID: <20200325181700.GD2116@tarantool.org> (raw)
In-Reply-To: <0450959d670b1a466f7bc2c3dccb6a5f6ca0a0b8.1585135623.git.imeevma@gmail.com>
On 25 Mar 14:38, imeevma@tarantool.org wrote:
> Hi! Thank you for review. My answers and new patch below.
>
> New patch:
>
> From 0450959d670b1a466f7bc2c3dccb6a5f6ca0a0b8 Mon Sep 17 00:00:00 2001
> From: Mergen Imeev <imeevma@gmail.com>
> Date: Wed, 25 Mar 2020 13:34:20 +0300
> Subject: [PATCH] sql: add '\0' to the BLOB when it is cast to INTEGER
>
> Prior to this patch, due to the absence of the '\0' character at
> the end of the BLOB, it was possible to get an error or incorrect
> result when using CAST() from BLOB to INTEGER or UNSIGNED. This
> has now been fixed, but the maximum length of a BLOB that could be
> cast to INTEGER or UNSIGNED was limited to 12287 bytes.
> Examples of wrong CAST() from BLOB to INTEGER:
>
> Error during CAST():
> tarantool> box.execute("CREATE TABLE t1 (a VARBINARY PRIMARY KEY);")
> ---
> - row_count: 1
> ...
Please strip all excess output (... --- etc).
next prev parent reply other threads:[~2020-03-25 18:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 11:38 [Tarantool-patches] [PATCH v3 0/2] sql: fix CAST() from BLOB " imeevma
2020-03-25 11:38 ` [Tarantool-patches] [PATCH v3 1/2] sql: fix CAST() from STRING " imeevma
2020-03-25 18:10 ` Nikita Pettik
2020-03-25 11:38 ` [Tarantool-patches] [PATCH v3 2/2] sql: add '\0' to the BLOB when it is cast " imeevma
2020-03-25 18:17 ` Nikita Pettik [this message]
2020-03-25 17:46 ` [Tarantool-patches] [PATCH v3 0/2] sql: fix CAST() from BLOB " Nikita Pettik
2020-03-27 11:30 ` Mergen Imeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325181700.GD2116@tarantool.org \
--to=korablev@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 2/2] sql: add '\''\0'\'' to the BLOB when it is cast to INTEGER' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox