Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Alexander Tikhonov <avtikhon@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>,
	tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2] test: fix OSX host setup
Date: Wed, 25 Mar 2020 16:38:39 +0300	[thread overview]
Message-ID: <20200325133839.pclhy6c7rjgkrdfk@tkn_work_nb> (raw)
In-Reply-To: <1585141973.158554584@f136.i.mail.ru>

> >> >> + brew update || echo | /usr/bin/ruby -e \
> >> >> + "$(curl -fsSL  https://raw.githubusercontent.com/Homebrew/install/master/install )"
> >> >
> >> >Why don't update formulae after installing brew?
> >>
> >> The tapped formula does not exist in brew any more, though it can’t be
> >> updated.
> >
> >After installing brew you'll have fresh brew, but no formulae, I guess.
> >Will the next `brew install` work? I guess, no. You need `brew update`
> >after this.
>
> I’ve tried to remove the brew and reinstalled it with this command,
> seems that all needed updates were tried to do during the
> installation:

Okay so.

> >> >From the previous review [1]:
> >> >
> >> >> > The problem with 'var' directory is not related to the new way to Python
> >> >> > 2 installation? Why everything is in one commit?
> >> >>
> >> >> This commit is about OSX host setup for building and testing, so I
> >> >> think it is ok to set it here.
> >> >
> >> >It sounds as 'because something going not right, when something was
> >> >changed'. Neat reason.
> >> >
> >> >I cannot say neither 'ok', not 'not ok' for this. Okay, I can guess that
> >> >working directory is changed somehow, but why and where?
> >>
> >> ‘var’ directory lays too deep at the path and the length of the path
> >> is too long for test-run.py tool which fails because of it, the
> >> solution to fix it is to use the short link for the ‘var’ directory.
> >
> >Why it was okay, but becomes too long?
> Because the name of the user on the new mac mini and its home path is really long
> echo ~ | wc -c
>       28
> also the path of tarantool/test/var adds.

Okay, so it worth to state something like:

> We're going to enable new Mac machines into CI and usernames on them
> are long according to internal policies. It makes a home directory to
> be long too and so a path to a unix socket created during testing can
> be longer then UNIX_PATH_MAX constant (108). Move the working
> directory for testing into <...>.

It would be also good to link the issue, which describes some details
around the path length limit:
https://github.com/tarantool/tarantool/issues/4634

  reply	other threads:[~2020-03-25 13:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23 18:09 Alexander V. Tikhonov
2020-03-25  7:59 ` Sergey Bronnikov
2020-03-25  8:27   ` Alexander Tikhonov
2020-03-25 11:38 ` Alexander Turenko
2020-03-25 12:12   ` Alexander Tikhonov
2020-03-25 12:30     ` Alexander Turenko
2020-03-25 13:12       ` Alexander Tikhonov
2020-03-25 13:38         ` Alexander Turenko [this message]
2020-03-25 14:34           ` Alexander Tikhonov
2020-03-26 12:49 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200325133839.pclhy6c7rjgkrdfk@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=o.piskunov@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2] test: fix OSX host setup' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox