Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 2/4] gc: rely on minimal vclock components instead of signatures
Date: Mon, 23 Mar 2020 19:40:25 +0300	[thread overview]
Message-ID: <20200323164025.GC5491@atlas> (raw)
In-Reply-To: <1888c3eba1eb272581916951759ef9ede0a34c07.1584978381.git.sergepetrenko@tarantool.org>

* Serge Petrenko <sergepetrenko@tarantool.org> [20/03/23 19:23]:
> +	struct vclock min_vclock;
> +	struct vclock *vclock;
> +	struct gc_consumer *consumer = gc_tree_first(&gc.consumers);
> +	if (consumer != NULL) {
> +		vclock_copy(&min_vclock, &consumer->vclock);
> +		while ((consumer = gc_tree_next(&gc.consumers, consumer)) != NULL) {
> +			vclock_min(&min_vclock, &consumer->vclock);
> +		}
> +		vclock_min(&min_vclock, &checkpoint->vclock);
> +		vclock = &min_vclock;
> +	} else {
> +		vclock =  &checkpoint->vclock;
> +	}

This loop is a total magic to anyone not present at our zoom
conversation. Please explain what's going on here in a comment.



-- 
Konstantin Osipov, Moscow, Russia
https://scylladb.com

  reply	other threads:[~2020-03-23 16:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23 16:19 [Tarantool-patches] [PATCH v3 0/4] replication: fix local space tracking Serge Petrenko
2020-03-23 16:19 ` [Tarantool-patches] [PATCH v3 1/4] vclock: add an ability to set individual clock components Serge Petrenko
2020-03-23 16:37   ` Konstantin Osipov
2020-03-27 10:22     ` Serge Petrenko
2020-03-23 16:19 ` [Tarantool-patches] [PATCH v3 2/4] gc: rely on minimal vclock components instead of signatures Serge Petrenko
2020-03-23 16:40   ` Konstantin Osipov [this message]
2020-03-27 10:24     ` Serge Petrenko
2020-03-23 16:19 ` [Tarantool-patches] [PATCH v3 3/4] replication: hide 0-th vclock components in replication responses Serge Petrenko
2020-03-23 16:42   ` Konstantin Osipov
2020-03-23 16:19 ` [Tarantool-patches] [PATCH v3 4/4] box: start counting local space requests separately Serge Petrenko
2020-03-23 16:51   ` Konstantin Osipov
2020-03-27 10:40     ` Serge Petrenko
2020-03-28 16:20       ` Konstantin Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200323164025.GC5491@atlas \
    --to=kostja.osipov@gmail.com \
    --cc=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v3 2/4] gc: rely on minimal vclock components instead of signatures' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox