Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] popen: add missing ev_io initialization
Date: Mon, 23 Mar 2020 14:09:46 +0300	[thread overview]
Message-ID: <20200323110946.GA3197@uranus> (raw)
In-Reply-To: <20200323104419.GB25473@tarantool.org>

On Mon, Mar 23, 2020 at 10:44:19AM +0000, Nikita Pettik wrote:
> On 23 Mar 10:32, Nikita Pettik wrote:
> > On 23 Mar 10:24, Cyrill Gorcunov wrote:
> > > Otherwise it left unitialized and in result
> > > may not work depending on dirty data got from
> > > memory.
> > > 
> > > Fixes #4811
> > > 
> > > Reported-by: Nikita Pettik <korablev@tarantool.org>
> > > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> > > ---
> > 
> > Hi,
> > 
> > Applying the patch does not fix the problem, but reproduce it
> > each time unit/ suite is executed :)
> 
> Sorry, I was wrong, still fails occasionally.

Been investigating it more -- this patch is redundant actually
and doesn't change anything thus could be dropped. Continue
diggin

      reply	other threads:[~2020-03-23 11:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23  7:24 Cyrill Gorcunov
2020-03-23 10:32 ` Nikita Pettik
2020-03-23 10:44   ` Nikita Pettik
2020-03-23 11:09     ` Cyrill Gorcunov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200323110946.GA3197@uranus \
    --to=gorcunov@gmail.com \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] popen: add missing ev_io initialization' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox