From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] vinyl: update mem ptr in vy_build_insert_tuple() after yield
Date: Fri, 20 Mar 2020 22:40:18 +0300 [thread overview]
Message-ID: <20200320194018.GE9483@atlas> (raw)
In-Reply-To: <20200320182423.GA15920@tarantool.org>
* Nikita Pettik <korablev@tarantool.org> [20/03/20 21:29]:
> > The problem is pretty minor. The fix is actually not necessarily
> > the best one, too (but seems adequate for 1.10).
>
> Could you please mention other ways to fix it? I'm still new in vinyl,
> so it would be helpful to me to investigate all possible solutions and
> workarounds. Thanks.
1) I'm really am not motivated to do it after the patch is pushed
like that.
2) There is vy_mem_pin/vy_mem_unpin which is used to pin the mem
during yields. Generally the mem we're working with should not
be kicked out of memory inside vy_build_insert_tuple, except for
when we deliberately wish it to happen in vy_quota_wait().
--
Konstantin Osipov, Moscow, Russia
https://scylladb.com
next prev parent reply other threads:[~2020-03-20 19:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 12:32 Nikita Pettik
2020-03-20 12:42 ` Nikita Pettik
2020-03-20 13:33 ` Konstantin Osipov
2020-03-20 15:06 ` Nikita Pettik
2020-03-20 15:19 ` Kirill Yukhin
2020-03-20 17:45 ` Konstantin Osipov
2020-03-20 17:40 ` Konstantin Osipov
2020-03-20 18:24 ` Nikita Pettik
2020-03-20 19:40 ` Konstantin Osipov [this message]
2020-03-20 15:23 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320194018.GE9483@atlas \
--to=kostja.osipov@gmail.com \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] vinyl: update mem ptr in vy_build_insert_tuple() after yield' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox