From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] vinyl: update mem ptr in vy_build_insert_tuple() after yield
Date: Fri, 20 Mar 2020 20:45:14 +0300 [thread overview]
Message-ID: <20200320174514.GB5670@atlas> (raw)
In-Reply-To: <20200320151936.6fmr5jkrkeqxwenc@tarantool.org>
* Kirill Yukhin <kyukhin@tarantool.org> [20/03/20 18:23]:
> It was mentioned multiple times, that we're using separate
> files for bug fixes (and will go further in future).
This works for gcc where each problem is usually a standalone
compilation unit, and once a compiler has run, it leaves no
memory/no state.
It's as terrible idea for a database, when one test case may
impact another, so putting test cases together has a sum effect.
Not to mention the speed of set up and tear down.
To sum up: yet another arrogant and arbitrary decision done
without due process.
In any case, my comment was not just about that. It was about a
yet another push without a proper second code review and
neglecting the previous reviewer's comments.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-03-20 17:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 12:32 Nikita Pettik
2020-03-20 12:42 ` Nikita Pettik
2020-03-20 13:33 ` Konstantin Osipov
2020-03-20 15:06 ` Nikita Pettik
2020-03-20 15:19 ` Kirill Yukhin
2020-03-20 17:45 ` Konstantin Osipov [this message]
2020-03-20 17:40 ` Konstantin Osipov
2020-03-20 18:24 ` Nikita Pettik
2020-03-20 19:40 ` Konstantin Osipov
2020-03-20 15:23 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320174514.GB5670@atlas \
--to=kostja.osipov@gmail.com \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] vinyl: update mem ptr in vy_build_insert_tuple() after yield' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox