From: Kirill Yukhin <kyukhin@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] vinyl: update mem ptr in vy_build_insert_tuple() after yield
Date: Fri, 20 Mar 2020 18:23:23 +0300 [thread overview]
Message-ID: <20200320152322.4cjwdfx7sqlnvxve@tarantool.org> (raw)
In-Reply-To: <59ece61283f53c6d2772b81ffc8a783873ef4b0b.1584703666.git.korablev@tarantool.org>
Hello,
On 20 мар 15:32, Nikita Pettik wrote:
> vy_build_insert_tuple() processes insertion into secondary indexes being
> created. It contains yield points during which in-memory level of LSM
> tree may change (for example rotate owing to triggered dump). So after
> yield point it is required to fetch from LSM struct pointer to mem again
> to operate on valid metadata. This patch updates pointer to mem after
> mentioned yield point.
>
> Closes #4810
> ---
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-4810-dump-during-index-build
> Issue: https://github.com/tarantool/tarantool/issues/4810
The patch LGTM.
I've checked it into 1.10, 2.2, 2.3 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-03-20 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 12:32 Nikita Pettik
2020-03-20 12:42 ` Nikita Pettik
2020-03-20 13:33 ` Konstantin Osipov
2020-03-20 15:06 ` Nikita Pettik
2020-03-20 15:19 ` Kirill Yukhin
2020-03-20 17:45 ` Konstantin Osipov
2020-03-20 17:40 ` Konstantin Osipov
2020-03-20 18:24 ` Nikita Pettik
2020-03-20 19:40 ` Konstantin Osipov
2020-03-20 15:23 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320152322.4cjwdfx7sqlnvxve@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] vinyl: update mem ptr in vy_build_insert_tuple() after yield' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox