From: Kirill Yukhin <kyukhin@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 0/2] test: cleanup tests code
Date: Fri, 20 Mar 2020 18:06:49 +0300 [thread overview]
Message-ID: <20200320150649.itr76mhwv5unswtv@tarantool.org> (raw)
In-Reply-To: <cover.1584708367.git.avtikhon@tarantool.org>
Hello,
On 20 мар 15:50, Alexander V. Tikhonov wrote:
> test: cleanup tests code
>
> Cleaned up the tests code according to the Lua style guide:
> - made scoped variables local
> - added os.exit call at the end of the test chunk
> - adjusted the messages in test:ok calls
>
> Renamed test files in the following way:
> <repo>-<number>-<comment>.test.lua
> where "<repo>" is github repository:
> gh - tarantool/tarantool
> lj - LuaJIT/LuaJIT
> or - openresty/luajit2
>
> Close #4655
>
> ---
>
> Github: https://github.com/tarantool/luajit/tree/avtikhon/gh-4655-cleanup-tests
> Issue: https://github.com/tarantool/tarantool/issues/4655
I've checked your patch into luajit repo and bumped a new version
in 1.10, 2.2, 2.3 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-03-20 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 12:50 Alexander V. Tikhonov
2020-03-20 12:50 ` [Tarantool-patches] [PATCH v3 1/2] " Alexander V. Tikhonov
2020-03-20 13:46 ` Igor Munkin
2020-03-20 14:10 ` Alexander Tikhonov
2020-03-20 12:50 ` [Tarantool-patches] [PATCH v3 2/2] test: rename test files Alexander V. Tikhonov
2020-03-20 13:47 ` Igor Munkin
2020-03-20 14:27 ` [Tarantool-patches] [PATCH v3 0/2] test: cleanup tests code Igor Munkin
2020-03-20 15:06 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320150649.itr76mhwv5unswtv@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 0/2] test: cleanup tests code' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox