From: Nikita Pettik <korablev@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>,
tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] vinyl: update mem ptr in vy_build_insert_tuple() after yield
Date: Fri, 20 Mar 2020 15:06:39 +0000 [thread overview]
Message-ID: <20200320150639.GC14930@tarantool.org> (raw)
In-Reply-To: <20200320133333.GB29536@atlas>
On 20 Mar 16:33, Konstantin Osipov wrote:
> * Nikita Pettik <korablev@tarantool.org> [20/03/20 15:41]:
> > vy_build_insert_tuple() processes insertion into secondary indexes being
> > created. It contains yield points during which in-memory level of LSM
> > tree may change (for example rotate owing to triggered dump). So after
> > yield point it is required to fetch from LSM struct pointer to mem again
> > to operate on valid metadata. This patch updates pointer to mem after
> > mentioned yield point.
>
> The patch is LGTM, how long does the test run?
Up to ~5 seconds as a rule.
> Can you add it to an existing low-quota test, to avoid
> setup/teardown overhead for such a minor fix?
Ok. But I woudn't say it is minor - bug leads to crashes under
highload on customer's servers :)
>
> --
> Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-03-20 15:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 12:32 Nikita Pettik
2020-03-20 12:42 ` Nikita Pettik
2020-03-20 13:33 ` Konstantin Osipov
2020-03-20 15:06 ` Nikita Pettik [this message]
2020-03-20 15:19 ` Kirill Yukhin
2020-03-20 17:45 ` Konstantin Osipov
2020-03-20 17:40 ` Konstantin Osipov
2020-03-20 18:24 ` Nikita Pettik
2020-03-20 19:40 ` Konstantin Osipov
2020-03-20 15:23 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320150639.GC14930@tarantool.org \
--to=korablev@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] vinyl: update mem ptr in vy_build_insert_tuple() after yield' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox