Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin <imun@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 0/2] test: cleanup tests code
Date: Fri, 20 Mar 2020 17:27:41 +0300	[thread overview]
Message-ID: <20200320142741.GT6392@tarantool.org> (raw)
In-Reply-To: <cover.1584708367.git.avtikhon@tarantool.org>

Kirill,

Please proceed with the series.

On 20.03.20, Alexander V. Tikhonov wrote:
> test: cleanup tests code
>     
> Cleaned up the tests code according to the Lua style guide:
> - made scoped variables local
> - added os.exit call at the end of the test chunk
> - adjusted the messages in test:ok calls
> 
> Renamed test files in the following way:
> <repo>-<number>-<comment>.test.lua
> where "<repo>" is github repository:
>   gh - tarantool/tarantool
>   lj - LuaJIT/LuaJIT
>   or - openresty/luajit2
>     
> Close #4655
> 
> ---
> 
> Github: https://github.com/tarantool/luajit/tree/avtikhon/gh-4655-cleanup-tests
> Issue: https://github.com/tarantool/tarantool/issues/4655
> 
> commit 1a00fc69881893cc376e78815fdfee12b9e038b3
> Author: Alexander V. Tikhonov <avtikhon@tarantool.org>
> Date:   Wed Dec 11 17:24:16 2019 +0300
> 
> Alexander V. Tikhonov (2):
>   test: cleanup tests code
>   test: rename test files
> 
>  ... gh-3196-incorrect-string-length.test.lua} |  8 +++----
>  ...h-4476-fix-string-find-recording.test.lua} |  6 ++---
>  ...lj-494-table-chain-infinite-loop.test.lua} | 23 ++++++++++---------
>  ...j-505-fold-no-strref-for-ptrdiff.test.lua} |  7 +++---
>  ...lj-524-fold-conv-respect-src-irt.test.lua} |  4 ++--
>  ...est.lua => or-232-unsink-64-kptr.test.lua} |  7 +++---
>  6 files changed, 29 insertions(+), 26 deletions(-)
>  rename test/{gh.test.lua => gh-3196-incorrect-string-length.test.lua} (56%)
>  rename test/{fix_string_find_recording.test.lua => gh-4476-fix-string-find-recording.test.lua} (95%)
>  rename test/{table_chain_bug_LuaJIT_494.test.lua => lj-494-table-chain-infinite-loop.test.lua} (89%)
>  rename test/{fold_bug_LuaJIT_505.test.lua => lj-505-fold-no-strref-for-ptrdiff.test.lua} (68%)
>  rename test/{fold_bug_LuaJIT_524.test.lua => lj-524-fold-conv-respect-src-irt.test.lua} (85%)
>  rename test/{unsink_64_kptr.test.lua => or-232-unsink-64-kptr.test.lua} (86%)
> 
> -- 
> 2.17.1
> 

-- 
Best regards,
IM

  parent reply	other threads:[~2020-03-20 14:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20 12:50 Alexander V. Tikhonov
2020-03-20 12:50 ` [Tarantool-patches] [PATCH v3 1/2] " Alexander V. Tikhonov
2020-03-20 13:46   ` Igor Munkin
2020-03-20 14:10     ` Alexander Tikhonov
2020-03-20 12:50 ` [Tarantool-patches] [PATCH v3 2/2] test: rename test files Alexander V. Tikhonov
2020-03-20 13:47   ` Igor Munkin
2020-03-20 14:27 ` Igor Munkin [this message]
2020-03-20 15:06 ` [Tarantool-patches] [PATCH v3 0/2] test: cleanup tests code Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200320142741.GT6392@tarantool.org \
    --to=imun@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v3 0/2] test: cleanup tests code' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox