Tarantool development patches archive
 help / color / mirror / Atom feed
From: Nikita Pettik <korablev@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] box.cfg() check memtx/vinyl_memory
Date: Fri, 20 Mar 2020 13:56:22 +0000	[thread overview]
Message-ID: <20200320135622.GB14930@tarantool.org> (raw)
In-Reply-To: <cover.1583366981.git.v.shpilevoy@tarantool.org>

On 05 Mar 01:14, Vladislav Shpilevoy wrote:
> The patchset fixes
> 1) forgotten diag_raise() for sql cache size check;
> 2) assertion when memtx_memory is too big.
> 
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4705-memtx-memory-too-big
> Issue: https://github.com/tarantool/tarantool/issues/4705
> 
> @ChangeLog
> - It is not possible to set memtx_memory and vinyl_memory more
>   than 4398046510080 bytes now (gh-4705).

Pushed first patch to master and 2.3, second one to master, 2.3 and 2.2.
Updated changelogs correspondingly. Branch is dropped.
 
> Vladislav Shpilevoy (2):
>   box: fail in box_check_config() on bad sql cache size
>   box: on cfg properly check memory quota
> 
>  src/box/box.cc        | 49 +++++++++++++++++++++----------------------
>  test/box/cfg.result   | 19 +++++++++++++++--
>  test/box/cfg.test.lua |  5 +++++
>  3 files changed, 46 insertions(+), 27 deletions(-)
> 
> -- 
> 2.21.1 (Apple Git-122.3)
> 

      parent reply	other threads:[~2020-03-20 13:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05  0:14 Vladislav Shpilevoy
2020-03-05  0:14 ` [Tarantool-patches] [PATCH 1/2] box: fail in box_check_config() on bad sql cache size Vladislav Shpilevoy
2020-03-05 11:35   ` Nikita Pettik
2020-03-05 20:53     ` Vladislav Shpilevoy
2020-03-05 21:00       ` Nikita Pettik
2020-03-05 21:17         ` Vladislav Shpilevoy
2020-03-19 15:27   ` Igor Munkin
2020-03-20  0:11     ` Vladislav Shpilevoy
2020-03-05  0:14 ` [Tarantool-patches] [PATCH 2/2] box: on cfg properly check memory quota Vladislav Shpilevoy
2020-03-05 11:41   ` Nikita Pettik
2020-03-20 13:56 ` Nikita Pettik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200320135622.GB14930@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/2] box.cfg() check memtx/vinyl_memory' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox