Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin <imun@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 1/2] test: cleanup tests code
Date: Fri, 20 Mar 2020 16:46:04 +0300	[thread overview]
Message-ID: <20200320134604.GR6392@tarantool.org> (raw)
In-Reply-To: <1a00fc69881893cc376e78815fdfee12b9e038b3.1584708367.git.avtikhon@tarantool.org>

Sasha,

Thanks for the patch! LGTM except the one general nit: please adjust
test:ok messages considering those I proposed in the previous review.

New series is not needed, just update the remote branch.

On 20.03.20, Alexander V. Tikhonov wrote:
> Cleaned up the tests code according to the Lua style guide:
> - made scoped variables local
> - added os.exit call at the end of the test chunk
> - adjusted the messages in test:ok calls
> 
> Part of #4655
> ---
>  test/fix_string_find_recording.test.lua  |  6 +++---
>  test/fold_bug_LuaJIT_505.test.lua        |  7 ++++---
>  test/fold_bug_LuaJIT_524.test.lua        |  4 ++--
>  test/gh.test.lua                         |  8 ++++----
>  test/table_chain_bug_LuaJIT_494.test.lua | 23 ++++++++++++-----------
>  test/unsink_64_kptr.test.lua             |  7 ++++---
>  6 files changed, 29 insertions(+), 26 deletions(-)
> 

<snipped>

> -- 
> 2.17.1
> 

-- 
Best regards,
IM

  reply	other threads:[~2020-03-20 13:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20 12:50 [Tarantool-patches] [PATCH v3 0/2] " Alexander V. Tikhonov
2020-03-20 12:50 ` [Tarantool-patches] [PATCH v3 1/2] " Alexander V. Tikhonov
2020-03-20 13:46   ` Igor Munkin [this message]
2020-03-20 14:10     ` Alexander Tikhonov
2020-03-20 12:50 ` [Tarantool-patches] [PATCH v3 2/2] test: rename test files Alexander V. Tikhonov
2020-03-20 13:47   ` Igor Munkin
2020-03-20 14:27 ` [Tarantool-patches] [PATCH v3 0/2] test: cleanup tests code Igor Munkin
2020-03-20 15:06 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200320134604.GR6392@tarantool.org \
    --to=imun@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v3 1/2] test: cleanup tests code' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox