From: Kirill Yukhin <kyukhin@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] vclock: refactor vclock map to use type uint32_t
Date: Fri, 20 Mar 2020 14:15:41 +0300 [thread overview]
Message-ID: <20200320111541.tiqcm27btztslate@tarantool.org> (raw)
In-Reply-To: <20200305113600.65203-1-sergepetrenko@tarantool.org>
Hello,
On 05 мар 14:36, Serge Petrenko wrote:
> We're using an unsigned int to hold vclock map, but there is no
> guarantee that unsigned int will be 4 bytes in size to fit all the 32
> vclock components. So use uint32_t instead.
> ---
> No issue, discussed in scope of
> https://github.com/tarantool/tarantool/issues/4739
> Branch: https://github.com/tarantool/tarantool/tree/sp/vclock-map-refactor
I've checked your patch into 2.2, 2.3 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-03-20 11:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 11:36 Serge Petrenko
2020-03-05 20:46 ` Vladislav Shpilevoy
2020-03-06 8:58 ` Serge Petrenko
2020-03-08 22:16 ` Vladislav Shpilevoy
2020-03-10 11:23 ` Serge Petrenko
2020-03-16 20:31 ` Konstantin Osipov
2020-03-19 14:36 ` Serge Petrenko
2020-03-19 14:47 ` Konstantin Osipov
2020-03-20 11:15 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320111541.tiqcm27btztslate@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] vclock: refactor vclock map to use type uint32_t' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox