From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Timur Safin <tsafin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
Cyrill Gorcunov <gorcunov@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1.2] evio: workaround for wsl1 so_linger assertion
Date: Thu, 19 Mar 2020 13:52:04 +0300 [thread overview]
Message-ID: <20200319105204.GW27301@uranus> (raw)
In-Reply-To: <0f1501d5fdd8$f21e6860$d65b3920$@tarantool.org>
On Thu, Mar 19, 2020 at 01:27:08PM +0300, Timur Safin wrote:
> SO_LINGER makes no much sense for unix-sockets, and Microsoft WSL
> is returning EINVAL if setsockopts called for SO_LINGER over unix
> sockets:
>
> [004] 2020-03-11 18:42:29.592 [29182] main/102/app sio.c:169 !> SystemError setsockopt(SO_LINGER), called on fd 16, aka
> [004] 2020-03-11 18:42:29.592 [29182] main/102/app F> can't initialize storage: setsockopt(SO_LINGER), called on fd 16,
> [004] 2020-03-11 18:42:29.592 [29182] main/102/app F> can't initialize storage: setsockopt(SO_LINGER), called on fd 16,
>
> And it's sort of correct here, but the problem is Linux is simply
> silently ignoring it, which passes tests.
>
> After much debates we decided to work-around this case via CMAKE
> define.
>
> NB! In a future (April/May 2020), when WSL2 with full Linux kernel
> would be released we should disable this check.
Hardly. This will break backward compatibility. Or we will have
to _require_ WSL2 to build tarantool.
next prev parent reply other threads:[~2020-03-19 10:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bb3eef527b48bdd3aacddc27e0597ceedcb84987.1584371177.git.tsafin@tarantool.org>
2020-03-16 16:53 ` [Tarantool-patches] [PATCH v1.1] " Timur Safin
2020-03-16 22:35 ` Vladislav Shpilevoy
2020-03-17 14:40 ` Timur Safin
2020-03-17 21:27 ` Vladislav Shpilevoy
2020-03-18 7:12 ` Timur Safin
2020-03-19 10:27 ` [Tarantool-patches] [PATCH v1.2] " Timur Safin
2020-03-19 10:52 ` Cyrill Gorcunov [this message]
2020-03-19 11:07 ` Timur Safin
2020-03-22 19:21 ` Vladislav Shpilevoy
2020-03-23 23:12 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319105204.GW27301@uranus \
--to=gorcunov@gmail.com \
--cc=gorcunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tsafin@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1.2] evio: workaround for wsl1 so_linger assertion' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox