From: Igor Munkin <imun@tarantool.org> To: Konstantin Osipov <kostja.osipov@gmail.com> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH 1/2] box: make box.cfg idempotent function Date: Thu, 19 Mar 2020 01:26:35 +0300 [thread overview] Message-ID: <20200318222635.GG6392@tarantool.org> (raw) In-Reply-To: <20200312200024.GA11476@atlas> Kostja, On 12.03.20, Konstantin Osipov wrote: > * Maria Khaydich <maria.khaydich@tarantool.org> [20/03/12 22:26]: > > >> Calling box.cfg{} more than once does not normally cause any errors > > >> (even though it might not have any effect). In contrast, assigning > > >> it to some variable and then using it after the box was configured > > >> caused an error since the method was overwritten by the initial call > > >> of <load_cfg>. > > >> > > >> The patch fixes this issue making box.cfg behave consistently in both > > >> scenarios and is a follow-up for box: make box.execute idempotent function. > > > > > >Did you benchmark it? > > > > Do you think we need to? There’s basically one extra condition > > in the patch. I don’t see how it might degrade performance. > > It's not a one more condition, it's one more FFI C call. I guess the problem have to be fixed anyway. However you might suggest another fix for the issue? There are several other ways to indicate whether box is configured, e.g. introduce the specific value to the box table. What do you think? I see for now box.cfg call as not the one performance critical, but I might be missing something you see. It would be great if you detailed a bit your proposal regarding the fix and its benchmarks. > > -- > Konstantin Osipov, Moscow, Russia -- Best regards, IM
next prev parent reply other threads:[~2020-03-18 22:32 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-14 11:50 [Tarantool-patches] [PATCH] box.execute should be immutable function Maria 2019-11-14 16:51 ` Nikita Pettik 2019-12-17 14:39 ` Igor Munkin 2019-12-24 15:32 ` [Tarantool-patches] [PATCH] box: make box.execute() immutable Maria Khaydich 2019-12-25 1:30 ` Igor Munkin 2019-12-26 14:08 ` Alexander Turenko 2020-01-13 12:13 ` Maria Khaydich 2020-01-13 15:48 ` Igor Munkin 2020-01-18 10:56 ` Maria Khaydich 2020-02-20 17:51 ` Alexander Turenko 2020-02-20 21:15 ` Igor Munkin 2020-03-11 15:56 ` Maria Khaydich 2020-03-18 22:25 ` Igor Munkin 2020-05-02 14:52 ` Alexander Turenko 2020-05-12 16:16 ` Alexander Turenko 2020-03-11 15:57 ` [Tarantool-patches] [PATCH 1/2] box: make box.cfg idempotent function Maria Khaydich 2020-03-12 13:29 ` Konstantin Osipov 2020-03-12 19:25 ` Maria Khaydich 2020-03-12 20:00 ` Konstantin Osipov 2020-03-18 22:26 ` Igor Munkin [this message] 2020-03-19 7:19 ` Konstantin Osipov 2020-03-19 9:08 ` Igor Munkin 2020-03-19 10:06 ` Konstantin Osipov 2020-03-19 10:26 ` Igor Munkin 2020-05-06 11:17 ` Alexander Turenko 2020-05-06 11:49 ` Konstantin Osipov 2020-05-06 12:53 ` Alexander Turenko 2020-05-06 13:02 ` Konstantin Osipov 2020-05-06 13:13 ` Alexander Turenko 2020-03-18 22:26 ` Igor Munkin 2020-05-12 16:17 ` Alexander Turenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200318222635.GG6392@tarantool.org \ --to=imun@tarantool.org \ --cc=kostja.osipov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 1/2] box: make box.cfg idempotent function' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox