From: Igor Munkin <imun@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 luajit 0/3] Introduce gdb extension for LuaJIT
Date: Wed, 18 Mar 2020 01:46:38 +0300 [thread overview]
Message-ID: <20200317224638.GD6392@tarantool.org> (raw)
In-Reply-To: <20200303223945.rsj6vm3h5asf63xn@tkn_work_nb>
Sasha,
On 04.03.20, Alexander Turenko wrote:
> I don't think that it worth to do in-depth review from my side. But I
> tried the extension, it works and gives output that I can interpret. It
> also has the documentation that is available using gdb's built-in help
> command. It is nice, thanks, Igor!
>
> So the patchset LGTM. CCed Kirill.
>
> Igor, please, file an issue for the further activity: we should ship the
> tool in our packages (possibly tarantool-dev/devel) in paths, where gdb
> will able to catch it automatically.
See #4808[1] for the further enhancements I proposed for the extension.
>
> WBR, Alexander Turenko.
>
<snipped>
[1]: https://github.com/tarantool/tarantool/issues/4808
--
Best regards,
IM
next prev parent reply other threads:[~2020-03-17 22:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 16:22 Igor Munkin
2020-02-05 16:22 ` [Tarantool-patches] [PATCH v2 luajit 1/3] gdb: introduce luajit-gdb extension Igor Munkin
2020-02-13 13:24 ` Igor Munkin
2020-02-05 16:22 ` [Tarantool-patches] [PATCH v2 luajit 2/3] gdb: adjust the extension to be used with Python 2 Igor Munkin
2020-02-05 16:22 ` [Tarantool-patches] [PATCH v2 luajit 3/3] gdb: enhance the extension loading Igor Munkin
2020-02-13 11:48 ` Igor Munkin
2020-02-13 12:24 ` Igor Munkin
2020-02-26 22:41 ` [Tarantool-patches] [PATCH v2 luajit 0/3] Introduce gdb extension for LuaJIT Alexander Turenko
2020-02-28 10:46 ` Igor Munkin
2020-03-02 16:00 ` Igor Munkin
2020-03-03 14:16 ` Sergey Ostanevich
2020-02-26 22:45 ` Alexander Turenko
2020-02-27 10:48 ` Igor Munkin
2020-02-27 11:35 ` Alexander Turenko
2020-03-03 16:17 ` Igor Munkin
2020-03-03 22:39 ` Alexander Turenko
2020-03-17 22:46 ` Igor Munkin [this message]
2020-02-26 23:04 ` Alexander Turenko
2020-02-27 10:13 ` Igor Munkin
2020-02-26 23:10 ` Alexander Turenko
2020-02-27 10:37 ` Igor Munkin
2020-03-05 7:44 ` Kirill Yukhin
2020-03-05 9:22 ` Igor Munkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317224638.GD6392@tarantool.org \
--to=imun@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 luajit 0/3] Introduce gdb extension for LuaJIT' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox