From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Georgy Kirichenko <kirichenkoga@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2] Add some cancellation guard
Date: Tue, 17 Mar 2020 22:16:03 +0300 [thread overview]
Message-ID: <20200317191603.GN27301@uranus> (raw)
In-Reply-To: <11490847.O9o76ZdvQC@localhost>
On Tue, Mar 17, 2020 at 09:49:14PM +0300, Georgy Kirichenko wrote:
...
> > > +
> > > + /*
> > > + * The thread should not be canceled while mutex is locked
> > > + */
> > > + int old_cancel_state;
> > > + tt_pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_cancel_state);
> >
> > Don't we need to disable cancel at the entry of this cpipe_destroy?
> > Thus trigger_destroy would be guarantee to finish, or it is not
> > that important in which moment we disable cancelling?
> >
> > Other than that the patch looks ok to me, still the overall cbus
> > code looks a bit fishy. Do we really need these threads to be
> > cancellable?
> A relay thread is canceled instead of gracefully exit. Despite relay exits
Oh my :(
> issue is addressed by my replication-form-memory patch I think this patch is
> useful.
As I pointed I'm ok with this patch since it address an issue.
Still I don't really like the overall design. But this is a
different story...
next prev parent reply other threads:[~2020-03-17 19:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 7:46 Leonid Vasiliev
2020-03-16 11:23 ` Cyrill Gorcunov
2020-03-17 18:49 ` Georgy Kirichenko
2020-03-17 19:16 ` Cyrill Gorcunov [this message]
2020-03-18 9:00 ` lvasiliev
2020-03-18 9:34 ` Cyrill Gorcunov
2020-03-18 8:26 ` Konstantin Osipov
2020-03-23 6:43 ` lvasiliev
2020-03-20 11:17 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317191603.GN27301@uranus \
--to=gorcunov@gmail.com \
--cc=kirichenkoga@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2] Add some cancellation guard' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox