Re: [Tarantool-patches] [PATCH v2 1/1] fiber: extend max fiber name length to 255

[Cyrill Gorcunov <gorcunov@gmail.com>]

On Mon, Mar 16, 2020 at 11:28:46PM +0100, Vladislav Shpilevoy wrote:
> Hi! Thanks for the review!
> 
> > Thank, Vlad! I like the patch. There is only one concern I have: for
> > some reason we has been defining faiber name as
> > 
> > char name[FIBER_NAME_MAX + 1];
> > 
> > where FIBER_NAME_MAX = 32 and finally this expands to "char name[33];"
> > I'm too lazy to find who exactly introduced this but it is bloody
> > wrong: compiler alings members to eliminate data access penalty, thus
> > _actually_ it will be defined as 8 multilier, ie 40 bytes.
> > 
> > Thus, if you don't mind I propose make FIBER_NAME_INLINE = 40
> > *including* string terminating zero.
> > 
> > Actually we can make it on top then. Up to you. Anyway
> > 
> > Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com>
> 
> Yes, good point.
> 
> Here is diff. The whole patch is in the bottom.

Thanks a huge, Vlad! My review tag remains.