From: Konstantin Osipov <kostja.osipov@gmail.com> To: Serge Petrenko <sergepetrenko@tarantool.org> Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Subject: Re: [Tarantool-patches] [PATCH] vclock: refactor vclock map to use type uint32_t Date: Mon, 16 Mar 2020 23:31:26 +0300 [thread overview] Message-ID: <20200316203126.GA14539@atlas> (raw) In-Reply-To: <20200305113600.65203-1-sergepetrenko@tarantool.org> * Serge Petrenko <sergepetrenko@tarantool.org> [20/03/05 14:36]: > We're using an unsigned int to hold vclock map, but there is no > guarantee that unsigned int will be 4 bytes in size to fit all the 32 > vclock components. So use uint32_t instead. I think there is a bunch of functions that still use unsigned to pass the vclock value around. Besides, if you work on a fix like that, it's best to use a typedef right away, so that it's easy to change to uint64t or 128 bit integer in the future. > No issue, discussed in scope of > https://github.com/tarantool/tarantool/issues/4739 > Branch: https://github.com/tarantool/tarantool/tree/sp/vclock-map-refactor -- Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-03-16 20:31 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-05 11:36 Serge Petrenko 2020-03-05 20:46 ` Vladislav Shpilevoy 2020-03-06 8:58 ` Serge Petrenko 2020-03-08 22:16 ` Vladislav Shpilevoy 2020-03-10 11:23 ` Serge Petrenko 2020-03-16 20:31 ` Konstantin Osipov [this message] 2020-03-19 14:36 ` Serge Petrenko 2020-03-19 14:47 ` Konstantin Osipov 2020-03-20 11:15 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200316203126.GA14539@atlas \ --to=kostja.osipov@gmail.com \ --cc=sergepetrenko@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] vclock: refactor vclock map to use type uint32_t' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox