From: Nikita Pettik <korablev@tarantool.org> To: Chris Sosnin <k.sosnin@tarantool.org> Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Subject: Re: [Tarantool-patches] [PATCH 4/4] sql: provide a user friendly frontend for accessing session settings Date: Mon, 16 Mar 2020 17:02:12 +0000 [thread overview] Message-ID: <20200316170212.GH14628@tarantool.org> (raw) In-Reply-To: <36341694915f89597f2ac938077d0d10bcad0448.1581940900.git.k.sosnin@tarantool.org> On 17 Feb 15:12, Chris Sosnin wrote: > Currently if a user wants to change session setting with sql, he has > to execute non-obvious query, thus, we introduce a more native way to > do this. It is not about non-obvious queries, but it is all about documentation: the better feature is described, the clearer its usage turns out to be for user. > Closes #4711 > > @TarantoolBot document > Title: API for accessing _session_settings space. > There are two ways of updating values of session settings: > via Lua and SQL. > > SQL: > Instead of typing long UPDATE query one can use the SET statement: > `box.execute([[SET "<setting_name>" = <new_value>]])`. > Note, that this query is case sensitive so the name must be quoted. > > Example: > ``` > tarantool> box.execute([[set "sql_default_engine" = 'memtx']]) > --- > - row_count: 1 > ... > > tarantool> box.execute([[set "sql_defer_foreign_keys" = true]]) Why didn't you consider show/get command to retrieve setting value? Otherwise, you simplify way to set session local options, but doesn't provide the same way to extract current values. > diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h > index d1fcf4761..3ffae5970 100644 > --- a/src/box/sql/sqlInt.h > +++ b/src/box/sql/sqlInt.h > @@ -4510,4 +4510,15 @@ int > sql_fieldno_by_name(struct Parse *parse_context, struct Expr *field_name, > uint32_t *fieldno); > > diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c > index 620d74e66..c81486fa6 100644 > --- a/src/box/sql/vdbe.c > +++ b/src/box/sql/vdbe.c > @@ -55,6 +55,7 @@ > #include "box/schema.h" > #include "box/space.h" > #include "box/sequence.h" > +#include "box/session_settings.h" > > /* > * Invoke this macro on memory cells just prior to changing the > @@ -5248,6 +5249,55 @@ case OP_IncMaxid: { > break; > } > > +/* Opcode: Set P1 P2 * * * > + * > + * Set the new value of the session setting. P1 is the id of the > + * setting in the session_settings array, P2 is the register > + * holding a value. > + */ > +case OP_Set: { Please, use more specific opcode name. Like OP_SettingSet.
next prev parent reply other threads:[~2020-03-16 17:02 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-17 12:12 [Tarantool-patches] [PATCH 0/4] box: session settings fixes Chris Sosnin 2020-02-17 12:12 ` [Tarantool-patches] [PATCH 1/4] box: replace session_settings modules with a single array Chris Sosnin 2020-02-17 12:12 ` [Tarantool-patches] [PATCH 2/4] box: add binary search for _session_settings space Chris Sosnin 2020-03-16 14:16 ` Nikita Pettik 2020-03-16 22:53 ` Vladislav Shpilevoy 2020-03-17 17:24 ` Nikita Pettik 2020-02-17 12:12 ` [Tarantool-patches] [PATCH 3/4] box: provide a user friendly frontend for accessing session settings Chris Sosnin 2020-03-16 16:08 ` Nikita Pettik 2020-03-16 22:53 ` Vladislav Shpilevoy 2020-03-17 14:27 ` Nikita Pettik 2020-03-17 14:36 ` Chris Sosnin 2020-02-17 12:12 ` [Tarantool-patches] [PATCH 4/4] sql: " Chris Sosnin 2020-03-16 17:02 ` Nikita Pettik [this message] 2020-03-16 22:53 ` Vladislav Shpilevoy 2020-03-17 17:26 ` Chris Sosnin 2020-03-17 20:12 ` Nikita Pettik 2020-03-17 21:00 ` Chris Sosnin 2020-03-18 10:00 ` Chris Sosnin -- strict thread matches above, loose matches on Subject: below -- 2020-03-30 9:13 [Tarantool-patches] [PATCH 0/4] session settings fixes Chris Sosnin 2020-03-30 9:13 ` [Tarantool-patches] [PATCH 4/4] sql: provide a user friendly frontend for accessing session settings Chris Sosnin 2020-04-03 15:19 ` Nikita Pettik 2020-04-04 21:56 ` Vladislav Shpilevoy 2020-04-10 15:40 ` Chris Sosnin 2020-04-11 17:18 ` Vladislav Shpilevoy 2020-04-13 7:50 ` Timur Safin 2020-02-03 22:17 [Tarantool-patches] [PATCH] " Vladislav Shpilevoy 2020-02-04 19:32 ` [Tarantool-patches] [PATCH 4/4] " Chris Sosnin 2020-02-06 22:16 ` Vladislav Shpilevoy 2020-02-07 9:40 ` Chris Sosnin 2020-02-10 22:09 ` Vladislav Shpilevoy 2020-02-17 11:46 ` Chris Sosnin 2020-02-17 11:56 ` Nikita Pettik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200316170212.GH14628@tarantool.org \ --to=korablev@tarantool.org \ --cc=k.sosnin@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 4/4] sql: provide a user friendly frontend for accessing session settings' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox