From: Kirill Yukhin <kyukhin@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/7] popen: various fixes and a test
Date: Mon, 16 Mar 2020 18:58:18 +0300 [thread overview]
Message-ID: <20200316155818.y3ttzndcexg4vm7x@tarantool.org> (raw)
In-Reply-To: <20200302201227.31785-1-gorcunov@gmail.com>
Hello,
On 02 мар 23:12, Cyrill Gorcunov wrote:
> Here are a few fixes for popen engine I discovered during
> testing on macos. Now the unit test passes.
>
> branch gorcunov/gh-4031-popen-fixup
>
> Cyrill Gorcunov (7):
> core/say: Export logger fd
> popen: allow accessing environ variable
> popen: close_inherited_fds - add support for macos/freebsd
> popen: log errors if popen creation failed
> popen: add logging in child process
> popen: handle setsid os specifics
> test/unit: add popen test
I've checked your patchset into master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-03-16 16:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 20:12 Cyrill Gorcunov
2020-03-02 20:12 ` [Tarantool-patches] [PATCH 1/7] core/say: Export logger fd Cyrill Gorcunov
2020-03-02 20:12 ` [Tarantool-patches] [PATCH 2/7] popen: allow accessing environ variable Cyrill Gorcunov
2020-03-02 20:12 ` [Tarantool-patches] [PATCH 3/7] popen: close_inherited_fds - add support for macos/freebsd Cyrill Gorcunov
2020-03-02 20:12 ` [Tarantool-patches] [PATCH 4/7] popen: log errors if popen creation failed Cyrill Gorcunov
2020-03-02 20:12 ` [Tarantool-patches] [PATCH 5/7] popen: add logging in child process Cyrill Gorcunov
2020-03-02 20:12 ` [Tarantool-patches] [PATCH 6/7] popen: handle setsid os specifics Cyrill Gorcunov
2020-03-03 11:38 ` Alexander Turenko
2020-03-03 11:45 ` Cyrill Gorcunov
2020-03-10 15:49 ` Alexander Turenko
2020-03-10 16:36 ` Alexander Turenko
2020-03-10 16:41 ` Cyrill Gorcunov
2020-03-10 17:12 ` Alexander Turenko
2020-03-10 17:40 ` Cyrill Gorcunov
2020-03-11 7:55 ` [Tarantool-patches] [PATCH v5 6/7] popen: handle sid on macos Cyrill Gorcunov
2020-03-06 14:30 ` [Tarantool-patches] [PATCH v2 6/7] popen: handle setsid os specifics Cyrill Gorcunov
2020-03-10 8:02 ` [Tarantool-patches] [PATCH v3 6/7] popen: use ioctl on macos Cyrill Gorcunov
2020-03-02 20:12 ` [Tarantool-patches] [PATCH 7/7] test/unit: add popen test Cyrill Gorcunov
2020-03-11 20:22 ` Alexander Turenko
2020-03-12 10:38 ` [Tarantool-patches] [PATCH v5 " Cyrill Gorcunov
2020-03-12 11:58 ` [Tarantool-patches] [PATCH 0/7] popen: various fixes and a test Alexander Turenko
2020-03-12 12:18 ` Cyrill Gorcunov
2020-03-16 15:58 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316155818.y3ttzndcexg4vm7x@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/7] popen: various fixes and a test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox