Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin <kyukhin@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: babinoleg@mail.ru, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] box.tuple.* cleanup
Date: Mon, 16 Mar 2020 17:07:55 +0300	[thread overview]
Message-ID: <20200316140755.rtcoezivs6hplcm5@tarantool.org> (raw)
In-Reply-To: <cover.1581790002.git.v.shpilevoy@tarantool.org>

Hello,

On 15 фев 19:08, Vladislav Shpilevoy wrote:
> The patchset removes or documents some internal functions in
> box.tuple.* namespace: box.tuple.bless()/encode()/is().
> 
> Bless() and encode() were moved to a more secret place, where
> suicidal users can't find it.
> 
> Is() is documented, because it is actually a useful thing.
> 
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4662-fiber-storage-leak
> Issue: https://github.com/tarantool/tarantool/issues/4662

The patch set LGTM.

--
Regards, Kirill Yukhin

  parent reply	other threads:[~2020-03-16 14:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-15 18:08 Vladislav Shpilevoy
2020-02-15 18:08 ` [Tarantool-patches] [PATCH 1/2] tuple: hide internal functions from box.tuple.* Vladislav Shpilevoy
2020-03-16 13:15   ` Nikita Pettik
2020-02-15 18:08 ` [Tarantool-patches] [PATCH 2/2] tuple: make box.tuple.is() public Vladislav Shpilevoy
2020-02-16 15:07   ` Vladislav Shpilevoy
2020-02-17 20:21     ` Oleg Babin
2020-02-17 21:11       ` Vladislav Shpilevoy
2020-03-16 13:19   ` Nikita Pettik
2020-02-15 19:02 ` [Tarantool-patches] [PATCH 0/2] box.tuple.* cleanup Oleg Babin
2020-02-16 15:07 ` Vladislav Shpilevoy
2020-03-01 14:21 ` Igor Munkin
2020-03-15 17:42 ` Vladislav Shpilevoy
2020-03-15 22:38   ` Nikita Pettik
2020-03-16 14:07 ` Kirill Yukhin [this message]
2020-03-16 17:48   ` Nikita Pettik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200316140755.rtcoezivs6hplcm5@tarantool.org \
    --to=kyukhin@tarantool.org \
    --cc=babinoleg@mail.ru \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/2] box.tuple.* cleanup' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox