From: Nikita Pettik <korablev@tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH 1/1] sql: trust column duplicate check to box Date: Mon, 16 Mar 2020 13:02:42 +0000 [thread overview] Message-ID: <20200316130242.GB14628@tarantool.org> (raw) In-Reply-To: <073c9b48376b0d53df7cc826a8774a7f4f35f087.1584293997.git.v.shpilevoy@tarantool.org> On 15 Mar 18:41, Vladislav Shpilevoy wrote: > CREATE TABLE used to check column name duplicates before going to > box. But it is not necessary, because the same check is done by > box. LGTM. Pushed to master as obvious. > --- > Branch: http://github.com/tarantool/tarantool/tree/gerold103/drop-column-duplicate-check-from-sql > > src/box/sql/build.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/src/box/sql/build.c b/src/box/sql/build.c > index fbfd05cbf..7511fad37 100644 > --- a/src/box/sql/build.c > +++ b/src/box/sql/build.c > @@ -324,13 +324,6 @@ sqlAddColumn(Parse * pParse, Token * pName, struct type_def *type_def) > pParse->is_aborted = true; > return; > } > - for (uint32_t i = 0; i < def->field_count; i++) { > - if (strcmp(z, def->fields[i].name) == 0) { > - diag_set(ClientError, ER_SPACE_FIELD_IS_DUPLICATE, z); > - pParse->is_aborted = true; > - return; > - } > - } > struct field_def *column_def = &def->fields[def->field_count]; > memcpy(column_def, &field_def_default, sizeof(field_def_default)); > column_def->name = z; > -- > 2.21.1 (Apple Git-122.3) >
prev parent reply other threads:[~2020-03-16 13:02 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-15 17:41 Vladislav Shpilevoy 2020-03-16 13:02 ` Nikita Pettik [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200316130242.GB14628@tarantool.org \ --to=korablev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 1/1] sql: trust column duplicate check to box' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox