From: Igor Munkin <imun@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2] build: disable LUAJIT_ENABLE_PAIRSMM
Date: Mon, 16 Mar 2020 13:12:51 +0300 [thread overview]
Message-ID: <20200316101251.GA6392@tarantool.org> (raw)
In-Reply-To: <155576cb-03e0-d83d-ac76-62d8f9c7bf0c@tarantool.org>
Vlad,
On 12.03.20, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
>
> > --- /dev/null
> > +++ b/test/box/gh-4770-broken-pairs-for-space-objects.result
> > @@ -0,0 +1,41 @@
> > +-- test-run result file version 2
> > +env = require('test_run')
> > + | ---
> > + | ...
> > +test_run = env.new()
> > + | ---
> > + | ...
> > +test_run:cmd("push filter 'table: .*' to 'table: <address>'")
>
> Why do you need the filter? There is nothing to filter out.
> You never print any 'table: .*' strings.
>
Thanks for your comment! I overlooked this line when copy-pasting the
preambule from box/misc.test.lua and I agree the filter is excess.
Fixed, squashed, force-pushed to the branch. Diff is below:
================================================================================
diff --git a/test/box/gh-4770-broken-pairs-for-space-objects.result b/test/box/gh-4770-broken-pairs-for-space-objects.result
index 3ac5995c2..c678714ee 100644
--- a/test/box/gh-4770-broken-pairs-for-space-objects.result
+++ b/test/box/gh-4770-broken-pairs-for-space-objects.result
@@ -1,14 +1,7 @@
-- test-run result file version 2
-env = require('test_run')
+test_run = require('test_run').new()
| ---
| ...
-test_run = env.new()
- | ---
- | ...
-test_run:cmd("push filter 'table: .*' to 'table: <address>'")
- | ---
- | - true
- | ...
--
-- gh-4770: Iteration through space with Lua builtin pairs routine
diff --git a/test/box/gh-4770-broken-pairs-for-space-objects.test.lua b/test/box/gh-4770-broken-pairs-for-space-objects.test.lua
index 315352b15..a1ba1eeab 100644
--- a/test/box/gh-4770-broken-pairs-for-space-objects.test.lua
+++ b/test/box/gh-4770-broken-pairs-for-space-objects.test.lua
@@ -1,6 +1,4 @@
-env = require('test_run')
-test_run = env.new()
-test_run:cmd("push filter 'table: .*' to 'table: <address>'")
+test_run = require('test_run').new()
--
-- gh-4770: Iteration through space with Lua builtin pairs routine
================================================================================
--
Best regards,
IM
next prev parent reply other threads:[~2020-03-16 10:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 16:28 Igor Munkin
2020-03-06 17:41 ` Igor Munkin
2020-03-11 23:19 ` Vladislav Shpilevoy
2020-03-16 10:12 ` Igor Munkin [this message]
2020-03-16 22:05 ` Vladislav Shpilevoy
2020-03-16 22:46 ` Igor Munkin
2020-03-17 7:30 ` Kirill Yukhin
2020-03-17 7:37 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316101251.GA6392@tarantool.org \
--to=imun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2] build: disable LUAJIT_ENABLE_PAIRSMM' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox