From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] test: use grep_log in tests
Date: Mon, 16 Mar 2020 12:42:21 +0300 [thread overview]
Message-ID: <20200316094221.ff6p6y4b3ip6k3rt@tkn_work_nb> (raw)
In-Reply-To: <baac6b6c-5057-8549-025a-3568e988e96a@tarantool.org>
On Tue, Mar 10, 2020 at 02:35:09PM +0300, Olga Arkhangelskaia wrote:
> Hi, Alexander!
>
> I have fixed things you have pointed out and pushed it to branch
>
> https://github.com/tarantool/tarantool/tree/OKriw/refactoring_of_panic_on_broken_lsn.test.lua
Pushed to master, 2.3, 2.2 and 1.10.
Found https://github.com/tarantool/tarantool/issues/4806 while testing
the change before push (looks unrelated to the change, so pushed
anyway).
CCed Kirill.
>
> The branch can not be tested without
>
> https://github.com/tarantool/test-run/tree/OKriw/gh-196-Extend-grep_log-for-crashed-instances
test-run part was pushed in
https://lists.tarantool.org/pipermail/tarantool-patches/2020-March/014786.html
> > > test: use grep_log in tests
> >
> > Nit: I would make the commit header a bit more certain and point the
> > test name right here.
>
> [PATCH] tests: use grep_log opt.filename in panic_on_broken_lsn
A bit changed: used 'test' prefix, removed 'opt'.
prev parent reply other threads:[~2020-03-16 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 6:44 Olga Arkhangelskaia
2020-03-04 15:31 ` Alexander Turenko
2020-03-10 11:35 ` Olga Arkhangelskaia
2020-03-16 9:42 ` Alexander Turenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316094221.ff6p6y4b3ip6k3rt@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=arkholga@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] test: use grep_log in tests' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox