Re: [Tarantool-patches] [PATCH] test_run: add path option to grep_log

[Alexander Turenko <alexander.turenko@tarantool.org>]

CCed the mail list.

----

(Sorry, forgot to send it at March, 12.)

Pushed to test-run with changes in the commit message (see below).
Updated the submodule in tarantool on the following branches: master,
2.3, 2.2 and 1.10.

CCed Kirill.

WBR, Alexander Turenko.

> > > While using grep_log it is useful to have a possibility to go through crashed
> > Please, keep a commit message body within 72 symbols.
> 
> [PATCH] test_run: add filename option to grep_log

Removed 'test_run:' prefix. It is convenient to determine a repository
in tarantool-patches mailing list, but have no much sense in the commit
itself (because it is already in test-run repository).

I suggest to use '--subject-prefix' option for 'git format-patch' when
preparing changes for a repository other then tarantool.

> 
> To search custom logs filename option of grep_log can be used.

Expanded the description a bit:

 | The option can be used when it is not possible to grab 'box.cfg.log'
 | value from a tarantool instance: say, when the instance is stopped or
 | crashed.

> Usage: grep_log(self, node, waht, bytes, {filename = XXX})

Fixed typo: waht.

I rewrote it a bit to avoid confusion with self / colon and so:

 | Usage:
 |
 |  | local test_run = require('test_run').new()
 |  | test_run:grep_log(node, what, bytes, {filename = <...>})

> 
> Closes #196
> 
> @Changelog
> Search custom log grep_log(self, node, waht, bytes, {filename = XXX})

Removed from the commit message. It should be in a email (at least for
tarantool), but should not be part of a commit message.