From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] fiber: extend max fiber name length to 255
Date: Sat, 14 Mar 2020 22:48:37 +0300 [thread overview]
Message-ID: <20200314194837.GX27301@uranus> (raw)
In-Reply-To: <86521117-2757-a564-a9ab-5c36041dca40@tarantool.org>
On Sat, Mar 14, 2020 at 06:32:01PM +0100, Vladislav Shpilevoy wrote:
> Besides, most of the users don't use long names. So for them
> it would be overkill to allocate such a big name memory for each
> fiber.
Look, currently all fiber data (including name) placed in one
continious memory area. After the patch the name gonna be "somewhere",
moreover this "somewhere" is completely unpredictable and access
to it will cause (i'm pretty sure) useless cache drains. If we
really need to support long names then we better make some union
which would carry both, short 32 byte names or long dynamically
allocated names.
And no, the statement "heap allocation doesn't affect anyone"
is simply wrong, this is not how memory works on a low level
(otherwise we wouldn't use "small" helpers at all, plain libc
malloc would fit us without a problem :).
next prev parent reply other threads:[~2020-03-14 19:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 15:16 Vladislav Shpilevoy
2020-03-14 16:34 ` Cyrill Gorcunov
2020-03-14 17:25 ` Vladislav Shpilevoy
2020-03-14 17:32 ` Vladislav Shpilevoy
2020-03-14 19:48 ` Cyrill Gorcunov [this message]
2020-03-15 15:13 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200314194837.GX27301@uranus \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] fiber: extend max fiber name length to 255' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox