Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] test_run: add path option to grep_log
Date: Fri, 13 Mar 2020 10:36:33 +0300	[thread overview]
Message-ID: <20200313073633.6febegmunj4flybq@tkn_work_nb> (raw)
In-Reply-To: <d3615520-de89-77f2-6b96-32e228412a3b@tarantool.org>

Pushed to test-run with changes in the commit message (see below).
Updated the submodule in tarantool on the following branches: master,
2.3, 2.2, 1.10.

CCed Kirill.

WBR, Alexander Turenko.

> > > While using grep_log it is useful to have a possibility to go through crashed
> > Please, keep a commit message body within 72 symbols.
> 
> [PATCH] test_run: add filename option to grep_log

Removed 'test_run:' prefix. It is convenient to determine a repository
in tarantool-patches mailing list, but have no much sense in the commit
itself (because it is already in test-run repository).

I suggest to use '--subject-prefix' option for 'git format-patch' when
preparing changes for a repository other then tarantool.

> 
> To search custom logs filename option of grep_log can be used.

Expanded the description a bit:

 | The option can be used when it is not possible to grab 'box.cfg.log'
 | value from a tarantool instance: say, when the instance is stopped or
 | crashed.


> Usage: grep_log(self, node, waht, bytes, {filename = XXX})

Fixed typo: waht.

I rewrote it a bit to avoid confusion with self / colon and so:

 | Usage:
 |
 |  | local test_run = require('test_run').new()
 |  | test_run:grep_log(node, what, bytes, {filename = <...>})

> 
> Closes #196
> 
> @Changelog
> Search custom log grep_log(self, node, waht, bytes, {filename = XXX})

Removed the changelog entry from the commit message. It should be in a
email (at least for tarantool), but should not be part of a commit
message.

  reply	other threads:[~2020-03-13  7:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-18 18:01 Olga Arkhangelskaia
2020-03-04 13:51 ` Alexander Turenko
2020-03-10 11:29   ` Olga Arkhangelskaia
2020-03-13  7:36     ` Alexander Turenko [this message]
     [not found]     ` <20200316091553.4hbyadvcubrpdzk4@tkn_work_nb>
2020-03-16  9:18       ` Alexander Turenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200313073633.6febegmunj4flybq@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=arkholga@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] test_run: add path option to grep_log' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox