From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Maria Khaydich <maria.khaydich@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/2] box: make box.cfg idempotent function
Date: Thu, 12 Mar 2020 16:29:31 +0300 [thread overview]
Message-ID: <20200312132931.GA30900@atlas> (raw)
In-Reply-To: <1583942274.319390956@f377.i.mail.ru>
* Maria Khaydich <maria.khaydich@tarantool.org> [20/03/11 19:02]:
>
> Calling box.cfg{} more than once does not normally cause any errors
> (even though it might not have any effect). In contrast, assigning
> it to some variable and then using it after the box was configured
> caused an error since the method was overwritten by the initial call
> of <load_cfg>.
>
> The patch fixes this issue making box.cfg behave consistently in both
> scenarios and is a follow-up for box: make box.execute idempotent function.
Did you benchmark it?
>
> Follow-up #4231
> ---
> Issue:
> https://github.com/tarantool/tarantool/issues/4231
> Branch:
> https://github.com/tarantool/tarantool/compare/eljashm/gh-4231-box.execute-immutable-function
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-03-12 13:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 11:50 [Tarantool-patches] [PATCH] box.execute should be immutable function Maria
2019-11-14 16:51 ` Nikita Pettik
2019-12-17 14:39 ` Igor Munkin
2019-12-24 15:32 ` [Tarantool-patches] [PATCH] box: make box.execute() immutable Maria Khaydich
2019-12-25 1:30 ` Igor Munkin
2019-12-26 14:08 ` Alexander Turenko
2020-01-13 12:13 ` Maria Khaydich
2020-01-13 15:48 ` Igor Munkin
2020-01-18 10:56 ` Maria Khaydich
2020-02-20 17:51 ` Alexander Turenko
2020-02-20 21:15 ` Igor Munkin
2020-03-11 15:56 ` Maria Khaydich
2020-03-18 22:25 ` Igor Munkin
2020-05-02 14:52 ` Alexander Turenko
2020-05-12 16:16 ` Alexander Turenko
2020-03-11 15:57 ` [Tarantool-patches] [PATCH 1/2] box: make box.cfg idempotent function Maria Khaydich
2020-03-12 13:29 ` Konstantin Osipov [this message]
2020-03-12 19:25 ` Maria Khaydich
2020-03-12 20:00 ` Konstantin Osipov
2020-03-18 22:26 ` Igor Munkin
2020-03-19 7:19 ` Konstantin Osipov
2020-03-19 9:08 ` Igor Munkin
2020-03-19 10:06 ` Konstantin Osipov
2020-03-19 10:26 ` Igor Munkin
2020-05-06 11:17 ` Alexander Turenko
2020-05-06 11:49 ` Konstantin Osipov
2020-05-06 12:53 ` Alexander Turenko
2020-05-06 13:02 ` Konstantin Osipov
2020-05-06 13:13 ` Alexander Turenko
2020-03-18 22:26 ` Igor Munkin
2020-05-12 16:17 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312132931.GA30900@atlas \
--to=kostja.osipov@gmail.com \
--cc=maria.khaydich@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/2] box: make box.cfg idempotent function' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox