From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/7] popen: various fixes and a test
Date: Thu, 12 Mar 2020 15:18:06 +0300 [thread overview]
Message-ID: <20200312121806.GO27301@uranus> (raw)
In-Reply-To: <20200312115842.q2gwcdkvolghalvu@tkn_work_nb>
On Thu, Mar 12, 2020 at 02:58:42PM +0300, Alexander Turenko wrote:
> I don't have objections anymore. LGTM.
>
> The actual version is on the branch gorcunov/gh-4031-popen-fixup-5.
>
> I'm a bit afraid that we don't test POPEN_FLAG_SETSID. However the code
> itself looks right and we maybe will return to this later.
>
> NB: We'll need to test two things to verify setsid():
>
> * The situation when a controlling terminal died. Maybe use screen /
> tmux here?
> * The ability to kill a spawned process group at whole (but w/o
> tarantool itself). Say, "sh -c 'foo | bar'".
>
> Pushed also gorcunov/gh-4031-popen-fixup-5-full-ci to verify on all
> targets (just in case). See results here:
> https://gitlab.com/tarantool/tarantool/pipelines/125648893 (they are now
> in fly).
Thanks a huge, Sasha! I think we continue fixing/extending popen engine.
next prev parent reply other threads:[~2020-03-12 12:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 20:12 Cyrill Gorcunov
2020-03-02 20:12 ` [Tarantool-patches] [PATCH 1/7] core/say: Export logger fd Cyrill Gorcunov
2020-03-02 20:12 ` [Tarantool-patches] [PATCH 2/7] popen: allow accessing environ variable Cyrill Gorcunov
2020-03-02 20:12 ` [Tarantool-patches] [PATCH 3/7] popen: close_inherited_fds - add support for macos/freebsd Cyrill Gorcunov
2020-03-02 20:12 ` [Tarantool-patches] [PATCH 4/7] popen: log errors if popen creation failed Cyrill Gorcunov
2020-03-02 20:12 ` [Tarantool-patches] [PATCH 5/7] popen: add logging in child process Cyrill Gorcunov
2020-03-02 20:12 ` [Tarantool-patches] [PATCH 6/7] popen: handle setsid os specifics Cyrill Gorcunov
2020-03-03 11:38 ` Alexander Turenko
2020-03-03 11:45 ` Cyrill Gorcunov
2020-03-10 15:49 ` Alexander Turenko
2020-03-10 16:36 ` Alexander Turenko
2020-03-10 16:41 ` Cyrill Gorcunov
2020-03-10 17:12 ` Alexander Turenko
2020-03-10 17:40 ` Cyrill Gorcunov
2020-03-11 7:55 ` [Tarantool-patches] [PATCH v5 6/7] popen: handle sid on macos Cyrill Gorcunov
2020-03-06 14:30 ` [Tarantool-patches] [PATCH v2 6/7] popen: handle setsid os specifics Cyrill Gorcunov
2020-03-10 8:02 ` [Tarantool-patches] [PATCH v3 6/7] popen: use ioctl on macos Cyrill Gorcunov
2020-03-02 20:12 ` [Tarantool-patches] [PATCH 7/7] test/unit: add popen test Cyrill Gorcunov
2020-03-11 20:22 ` Alexander Turenko
2020-03-12 10:38 ` [Tarantool-patches] [PATCH v5 " Cyrill Gorcunov
2020-03-12 11:58 ` [Tarantool-patches] [PATCH 0/7] popen: various fixes and a test Alexander Turenko
2020-03-12 12:18 ` Cyrill Gorcunov [this message]
2020-03-16 15:58 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312121806.GO27301@uranus \
--to=gorcunov@gmail.com \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/7] popen: various fixes and a test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox