From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Alexander Tikhonov <avtikhon@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] test: add more tests to packaging testing
Date: Thu, 12 Mar 2020 14:03:52 +0300 [thread overview]
Message-ID: <20200312110352.gmsgjhbx6y7hff4a@tkn_work_nb> (raw)
In-Reply-To: <1583924700.513372502@f460.i.mail.ru>
> >> # For tests
> >> -%if (0%{?fedora} >= 22 || 0%{?rhel} == 7)
> >> -BuildRequires: python >= 2.7
> >> -BuildRequires: python-six >= 1.9.0
> >> -BuildRequires: python-gevent >= 1.0
> >> -BuildRequires: python-yaml >= 3.0.9
> >> -%endif
> >> %if (0%{?fedora} >= 31 || 0%{?rhel} >= 8)
> >> BuildRequires: python2 >= 2.7
> >> BuildRequires: python2-six >= 1.9.0
> >> BuildRequires: python2-gevent >= 1.0
> >> BuildRequires: python2-yaml >= 3.0.9
> >> +%else
> >> +%if (0%{?rhel} != 6)
> >
> >Don't understood: what was actually changed? We have Fedora 28-31 and
> >CentOS 6-8 in testing / deploying.
> Please check the next comment.
> >
> >
> >> +BuildRequires: python >= 2.7
> >> +BuildRequires: python-six >= 1.9.0
> >> +BuildRequires: python-gevent >= 1.0
> >> +BuildRequires: python-yaml >= 3.0.9
> >> +%endif
> >> %endif
> >>
> In the current change and one before, the check of the versions added. Before it
> was that only Fedora and CentOS installed the python packages for the testing.
> As after the change all OSs (except CentOS 6) will have it installed except
> Fedora since 31 version and CentOS since 8 version will have python2.
After I discussed it voicely with Alexander I got what was changed.
Fedora 31 and CentOS 8 installs both python-foo and python2-foo
dependencies, while python-foo is actually alias for python3-foo. It
does not fail the build, but is not used.
I'm okay to remove unused Python 3 deps, but let's add a comment here
(right in the spec): it is not obvious, you see.
> >> %check
> >> -%if (0%{?fedora} >= 22 || 0%{?rhel} >= 7)
> >> # https://github.com/tarantool/tarantool/issues/1227
> >> echo "self.skip = True" > ./test/app/socket.skipcond
> >> # https://github.com/tarantool/tarantool/issues/1322
> >> echo "self.skip = True" > ./test/app/digest.skipcond
> >
> >Those two issues now closed. Maybe it is time to enable those tests?
> Sure, I'll add separate commit into the current patch set.
As I see on the branch (avtikhon/gh-4599-packages-testing-full-ci), you
removed it right in this commit. Anyway, it is okay for me.
> >> -cd test && ./test-run.py --force -j 1 unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/
> >> +%if (0%{?rhel} != 6)
> >> + TEST_RUN_EXCLUDE='replication/' make test-force
> >> %endif
> >
> >Flaky fails rate will increase on Travis-CI if we'll enable
> >parallelization. Either discard this change or enable it only for
> >gitlab-ci.
> Added mark 'IS_TRAVIS' to be changed by packpack on run.
Commented in https://github.com/packpack/packpack/pull/116
next prev parent reply other threads:[~2020-03-12 11:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 11:10 Alexander V. Tikhonov
2020-02-21 11:19 ` Alexander Turenko
2020-03-11 11:05 ` Alexander Tikhonov
2020-03-12 11:03 ` Alexander Turenko [this message]
2020-03-13 4:45 ` Alexander Tikhonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312110352.gmsgjhbx6y7hff4a@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=o.piskunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] test: add more tests to packaging testing' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox