Re: [Tarantool-patches] [PATCH 1/3] box: fix struct port_tuple.size wrong type in Lua

[Nikita Pettik <korablev@tarantool.org>]

On 08 Mar 18:47, Vladislav Shpilevoy wrote:
> Original port_tuple in C has 'int size;' field. It was
> 'size_t size' in Lua. Since sizeof(size_t) usually is
> 8, and sizeof(int) is 4, this was a really bad typo.

LGTM (feel free to push out of order as obvious).

> ---
>  src/box/lua/schema.lua | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/box/lua/schema.lua b/src/box/lua/schema.lua
> index f537c3cec..aba439ffb 100644
> --- a/src/box/lua/schema.lua
> +++ b/src/box/lua/schema.lua
> @@ -84,7 +84,7 @@ ffi.cdef[[
>  
>      struct port_tuple {
>          const struct port_vtab *vtab;
> -        size_t size;
> +        int size;
>          struct port_tuple_entry *first;
>          struct port_tuple_entry *last;
>          struct port_tuple_entry first_entry;
> -- 
> 2.21.1 (Apple Git-122.3)
>