From: Nikita Pettik <korablev@tarantool.org>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v6] memtx: fix out of memory handling for rtree
Date: Tue, 10 Mar 2020 13:34:46 +0000 [thread overview]
Message-ID: <20200310133446.GA26141@tarantool.org> (raw)
In-Reply-To: <996b64f7-95f8-e8aa-a327-ec63398e12f5@tarantool.org>
On 10 Mar 14:25, Olga Arkhangelskaia wrote:
> Done.
Pushed to master, 2.3, 2.2 and 1.10. Updated changelogs for
branches correspondingly.
> 05.03.2020 0:18, Nikita Pettik пишет:
> > On 03 Mar 14:50, Olga Arkhangelskaia wrote:
> > > Hi Sergey! I need time to check everything!
> > >
> > > I can not use error injection that exists in memtx_index_extent_reserve(),
> > >
> > > because it is used in memtx_space_replace_all_keys ant it is called prior
> > > memtx_rtree_index_reserve() .
> > >
> > > If we use memtx_index_extent_reserve(), injection we will not reach the
> > > place where error with rtree occures.
> > >
> > > So to make sure that we fixed the problem we need
> > > memtx_rtree_index_reserve() to fail.
> > >
> > Since now patch received two acks, it is ready to be pushed.
> > Olga, could you please rebase branch on the top of master (there's several
> > merge conflicts) and provide brief @changelog (a few sentences for casual
> > Tarantool users concerning visible changes this patch introduces)? As soon
> > as it is ready, I'll push it. Thanks.
> >
prev parent reply other threads:[~2020-03-10 13:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 7:47 Olga Arkhangelskaia
2020-02-10 11:18 ` Nikita Pettik
2020-02-11 10:33 ` Olga Arkhangelskaia
2020-02-11 10:51 ` Olga Arkhangelskaia
2020-02-11 12:42 ` Nikita Pettik
2020-02-18 12:46 ` Sergey Ostanevich
2020-02-18 18:20 ` Olga Arkhangelskaia
2020-02-19 16:28 ` Sergey Ostanevich
2020-03-03 11:50 ` Olga Arkhangelskaia
2020-03-03 14:17 ` Sergey Ostanevich
2020-03-04 21:18 ` Nikita Pettik
2020-03-10 11:25 ` Olga Arkhangelskaia
2020-03-10 13:34 ` Nikita Pettik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310133446.GA26141@tarantool.org \
--to=korablev@tarantool.org \
--cc=arkholga@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v6] memtx: fix out of memory handling for rtree' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox