From: Konstantin Osipov <kostja.osipov@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 09/10] box/journal: journal_entry_new -- drop setting up callbacks
Date: Sat, 7 Mar 2020 01:04:19 +0300 [thread overview]
Message-ID: <20200306220419.GB6478@atlas> (raw)
In-Reply-To: <20200306215755.GC27301@uranus>
* Cyrill Gorcunov <gorcunov@gmail.com> [20/03/07 00:59]:
> To be honest -- I don't know at the moment. This is replication test
> if I understand correctly and I presume these are async calls, but
> not sure yet. What is interesting is that vinyl internally use
> journal entries and calls cbus directly to write the data (again,
> if I understand correctly 'cause I know nothing about vinyl internals)
> and this might be the reason.
it just reuses the wal thread infrastructure, but this is a completely
different code path, not related to your changes at all.
your crash is in txn_complete(), it seems, which is not called for
vinyl vy_log entry at all, there are no callbacks and it uses
cbus_call(), so there is no entry batching either.
--
Konstantin Osipov, Moscow, Russia
next prev parent reply other threads:[~2020-03-06 22:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 12:29 [Tarantool-patches] [PATCH 00/10] box/journal: redesign sync and async writes Cyrill Gorcunov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 01/10] box: recovery_journal_create -- set journal here Cyrill Gorcunov
2020-03-06 21:27 ` Konstantin Osipov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 02/10] box/txn: move fiber_set_txn to header Cyrill Gorcunov
2020-03-06 21:27 ` Konstantin Osipov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 03/10] box/txn: rename txn_write to txn_commit_async Cyrill Gorcunov
2020-03-06 21:28 ` Konstantin Osipov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 04/10] box/txn: move setup of txn start to txn_prepare Cyrill Gorcunov
2020-03-06 21:30 ` Konstantin Osipov
2020-03-18 12:38 ` Cyrill Gorcunov
2020-03-18 13:58 ` Konstantin Osipov
2020-03-18 14:09 ` Cyrill Gorcunov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 05/10] box/txn: add txn_commit_nop helper Cyrill Gorcunov
2020-03-06 21:30 ` Konstantin Osipov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 06/10] box/txn: unweave txn_commit from txn_commit_async Cyrill Gorcunov
2020-03-06 21:33 ` Konstantin Osipov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 07/10] box/txn: clear fiber storage right before journal write Cyrill Gorcunov
2020-03-06 21:34 ` Konstantin Osipov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 08/10] box/txn: move journal allocation into separate routine Cyrill Gorcunov
2020-03-06 21:35 ` Konstantin Osipov
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 09/10] box/journal: journal_entry_new -- drop setting up callbacks Cyrill Gorcunov
2020-03-06 21:37 ` Konstantin Osipov
2020-03-06 21:41 ` Cyrill Gorcunov
2020-03-06 21:51 ` Konstantin Osipov
2020-03-06 21:57 ` Cyrill Gorcunov
2020-03-06 22:04 ` Konstantin Osipov [this message]
2020-03-05 12:29 ` [Tarantool-patches] [PATCH 10/10] box/journal: redesign sync and async writes Cyrill Gorcunov
2020-03-06 21:48 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306220419.GB6478@atlas \
--to=kostja.osipov@gmail.com \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 09/10] box/journal: journal_entry_new -- drop setting up callbacks' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox